POTEL 35 - Use OtelSpan name as fallback for transaction name#3557
Merged
POTEL 35 - Use OtelSpan name as fallback for transaction name#3557
Conversation
Contributor
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a0f7731 | 357.02 ms | 433.40 ms | 76.38 ms |
| 2f49b9c | 416.54 ms | 479.14 ms | 62.60 ms |
| a59fca2 | 560.08 ms | 658.80 ms | 98.71 ms |
| 57732e8 | 435.66 ms | 510.50 ms | 74.84 ms |
| ca82680 | 490.88 ms | 631.67 ms | 140.80 ms |
| 41e496a | 408.90 ms | 491.32 ms | 82.42 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a0f7731 | 1.70 MiB | 2.29 MiB | 599.77 KiB |
| 2f49b9c | 1.70 MiB | 2.29 MiB | 599.31 KiB |
| a59fca2 | 1.70 MiB | 2.29 MiB | 599.77 KiB |
| 57732e8 | 1.70 MiB | 2.29 MiB | 599.77 KiB |
| ca82680 | 1.70 MiB | 2.29 MiB | 599.31 KiB |
| 41e496a | 1.70 MiB | 2.29 MiB | 599.77 KiB |
adinauer
approved these changes
Jul 10, 2024
Member
adinauer
left a comment
There was a problem hiding this comment.
LGTM, just needs a changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fallback to otelspan name as transaction description if sentry span description is null
💡 Motivation and Context
Avoid having
<unlabeled transaction>as label in sentry.💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps