feat: Make upstream dependencies compileOnly in integrations#2175
Merged
feat: Make upstream dependencies compileOnly in integrations#2175
Conversation
Contributor
|
bruno-garcia
approved these changes
Jul 15, 2022
Member
bruno-garcia
left a comment
There was a problem hiding this comment.
LGTM. Maybe @adinauer or @marandaneto want to 👀 ?
philipphofmann
approved these changes
Jul 18, 2022
Member
philipphofmann
left a comment
There was a problem hiding this comment.
LGTM, but maybe we should add more detail to the error messages somewhere.
sentry-android-core/src/main/java/io/sentry/android/core/SentryAndroid.java
Show resolved
Hide resolved
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Switch to compileOnly upstream dependencies in integrations, so we do not override user-defined version and use what they actually have on their classpath.
💡 Motivation and Context
Closes #2125
💚 How did you test it?
Tested manually here and on SAGP
📝 Checklist
🔮 Next steps
@adinauer I'm not sure if you want to do this for backend things, I think it can also be applicable there? We could create another issue, for now I'm afraid of breaking something there