Fix: Do not start fragment span if not added to the Activity#1813
Merged
marandaneto merged 2 commits intomainfrom Nov 18, 2021
Merged
Fix: Do not start fragment span if not added to the Activity#1813marandaneto merged 2 commits intomainfrom
marandaneto merged 2 commits intomainfrom
Conversation
4 tasks
romtsn
approved these changes
Nov 18, 2021
...ndroid-fragment/src/main/java/io/sentry/android/fragment/SentryFragmentLifecycleCallbacks.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix: Do not start fragment span if not added to the Activity
💡 Motivation and Context
Closes #1787
💚 How did you test it?
running https://github.com/LouisFn/SentryFrozenFrame and repo's sample with added/visible fragments
📝 Checklist
🔮 Next steps