Problem Statement
Currently, SentryWebfluxAutoConfiguration registers the legacy filter (SentryWebfluxFilterConfiguration) whenever the property sentry.reactive.thread-local-accessor-enabled is not set. As a result, users who omit that property miss out on the benefits of the newer ThreadLocalAccessor-based filter.
Changing the default to SentryWebfluxFilterThreadLocalAccessorConfiguration would allow more users to benefit from improved context propagation without extra configuration.
Solution Brainstorm
Sentry 8.0.0 release candidate is in progress, so this is a good time to adjust the default behavior.
I propose:
- Add
matchIfMissing = true to the @ConditionalOnProperty in SentryThreadLocalAccessorCondition.
- Remove
matchIfMissing = true from SentryDisableThreadLocalAccessorCondition.
This way, SentryWebfluxFilterThreadLocalAccessorConfiguration is used when sentry.reactive.thread-local-accessor-enabled is not explicitly defined.
Users who still prefer the legacy filter can explicitly set sentry.reactive.thread-local-accessor-enabled=false.
Problem Statement
Currently,
SentryWebfluxAutoConfigurationregisters the legacy filter (SentryWebfluxFilterConfiguration) whenever the propertysentry.reactive.thread-local-accessor-enabledis not set. As a result, users who omit that property miss out on the benefits of the newer ThreadLocalAccessor-based filter.Changing the default to
SentryWebfluxFilterThreadLocalAccessorConfigurationwould allow more users to benefit from improved context propagation without extra configuration.Solution Brainstorm
Sentry 8.0.0 release candidate is in progress, so this is a good time to adjust the default behavior.
I propose:
matchIfMissing = trueto the@ConditionalOnPropertyinSentryThreadLocalAccessorCondition.matchIfMissing = truefromSentryDisableThreadLocalAccessorCondition.This way,
SentryWebfluxFilterThreadLocalAccessorConfigurationis used whensentry.reactive.thread-local-accessor-enabledis not explicitly defined.Users who still prefer the legacy filter can explicitly set
sentry.reactive.thread-local-accessor-enabled=false.