Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.76%. Comparing base (3c523e2) to head (988249a).

@@            Coverage Diff             @@
##           master     #722      +/-   ##
==========================================
+ Coverage   81.59%   81.76%   +0.16%     
==========================================
  Files          48       48              
  Lines        4717     4759      +42     
==========================================
+ Hits         3849     3891      +42     
  Misses        728      728              
  Partials      140      140              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aldy505 is there any news regarding the implementation? I could really use this

@aldy505 is there any news regarding the implementation? I could really use this

Michi (@cleptric) said to me a few weeks (or month?) ago over Discord that the Go SDK would need to prioritize to convert every performance section to use OpenTelemetry under the hood first before any other changes. That.. would mean this PR is on hold until the performance section is refactored.

Now, for you, would obviously not a good idea to wait for this PR to be merged. But one thing you can do is to copy and paste everything inside the echo directory (exclude the test, it's fine) to your project as your own "sentryecho" package. Then import your own "sentryecho" package instead of this one. I think that is doable on your part.

Since the perf by otel is on halt, here's a gentle ping @cleptric

I wanted to add starfish properties (or otel properties, really) as seen in #786, but I think it's better for this and #723 to be merged first, and I update #786 to include both echo and fasthttp. Or.. it can be a separate PR.

LGTM, thanks.

Any chance you could add a changelog entry?

@vaind in 3-4 hours from now

LGTM, thanks.
Any chance you could add a changelog entry?

@vaind in 3-4 hours from now

I've noticed this repo doesn't have rules to prepare changelog in advance with PRs. Added #799 to fix that, afterwards we can add the entry in this PR.