feat(performance): start transaction for fasthttp integration#723
Merged
vaind merged 10 commits intogetsentry:masterfrom Mar 26, 2024
Merged
feat(performance): start transaction for fasthttp integration#723vaind merged 10 commits intogetsentry:masterfrom
vaind merged 10 commits intogetsentry:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #723 +/- ##
==========================================
+ Coverage 81.84% 81.93% +0.08%
==========================================
Files 48 48
Lines 4759 4782 +23
==========================================
+ Hits 3895 3918 +23
Misses 725 725
Partials 139 139 ☔ View full report in Codecov by Sentry. |
ribice
approved these changes
Mar 24, 2024
vaind
suggested changes
Mar 26, 2024
vaind
approved these changes
Mar 26, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that only a few integration starts performance span for their HTTP handlers (such as net/http and Gin), the others are not. Here is my effort on fixing it for other integrations/frameworks.
This also introduces the
GetTransactionFromContextfunction that takes thefasthttp.RequestCtxas input and returns*sentry.Spanornil. It handles thatfasthttp.RequestCtx's context is not compatible with oursentry.GetHubFromContextdue to different format of context key.Discord link: https://discord.com/channels/621778831602221064/621786587939864586/1157114103156969513