ref!: remove Experimental from Metrics API#5023
Conversation
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Breaking Changes 🛠
Dependencies ⬆️Deps
🤖 This preview updates automatically when you update the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5023 +/- ##
==========================================
+ Coverage 73.92% 73.95% +0.02%
==========================================
Files 497 497
Lines 17974 17966 -8
Branches 3517 3516 -1
==========================================
- Hits 13287 13286 -1
+ Misses 3832 3823 -9
- Partials 855 857 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This again:
I bump into this once or twice a day... just costs time requeusting gh rerun the jobs and then coming back later to do actual reviews/approvals. It should hopefully be addressed by #4956. @Flash0ver I think we should get that merged in to check (we can always revert if it doesn't work). |
## DESCRIBE YOUR PR With the next release of the Sentry .NET SDK - expected to be `v6.3.0` - the Metrics APIs are no longer `Experimental`. This changeset updates the respective C# code snippets. Related PRs: - getsentry/sentry-dotnet#5023 - getsentry/sentry#110636 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [x] Other deadline: Release of the Sentry .NET SDK v6.3.0 - [ ] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [x] Checked Vercel preview for correctness, including links - [x] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [x] @jamescrosswell - [x] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) Co-authored-by: James Crosswell <jamescrosswell@users.noreply.github.com>
## DESCRIBE YOUR PR With the next release of the Sentry .NET SDK - expected to be `v6.3.0` - the Metrics APIs are no longer `Experimental`. This changeset updates the respective C# code snippets. Related PRs: - getsentry/sentry-dotnet#5023 - getsentry/sentry#110636 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [x] Other deadline: Release of the Sentry .NET SDK v6.3.0 - [ ] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [x] Checked Vercel preview for correctness, including links - [x] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [x] @jamescrosswell - [x] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) Co-authored-by: James Crosswell <jamescrosswell@users.noreply.github.com>
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Sentry.Maui](https://sentry.io/) ([source](https://github.com/getsentry/sentry-dotnet)) | nuget | minor | `6.2.0` -> `6.3.0` | --- ### Release Notes <details> <summary>getsentry/sentry-dotnet (Sentry.Maui)</summary> ### [`v6.3.0`](https://github.com/getsentry/sentry-dotnet/blob/HEAD/CHANGELOG.md#630) [Compare Source](getsentry/sentry-dotnet@6.2.0...6.3.0) ##### Features - The *Metrics* APIs are now stable: removed `Experimental` from `SentrySdk`, `SentryOptions` and `IHub` ([#​5023](getsentry/sentry-dotnet#5023)) - Report a new *Diagnostic* (`SENTRY1001`) when a Metrics-API is invoked with an unsupported numeric type ([#​4840](getsentry/sentry-dotnet#4840)) ##### Fixes - Common tags such as `Environment` and `Release` and custom event processors are all now correctly applied to CaptureFeedback events ([#​4942](getsentry/sentry-dotnet#4942)) - Include `Data` set via `ITransactionTracer` in `SentryTransaction` ([#​4148](getsentry/sentry-dotnet#4148)) ##### Dependencies - Bump Cocoa SDK from v9.5.0 to v9.7.0 ([#​4958](getsentry/sentry-dotnet#4958), [#​5015](getsentry/sentry-dotnet#5015)) - Bump CLI from v3.3.0 to v3.3.3 ([#​5002](getsentry/sentry-dotnet#5002)) - Bump Java SDK from v8.34.1 to v8.35.0 ([#​5017](getsentry/sentry-dotnet#5017)) - Bump Native SDK from v0.13.2 to v0.13.3 ([#​5045](getsentry/sentry-dotnet#5045)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or PR is renamed to start with "rebase!". 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
…3244) Pinned [Sentry.AspNetCore](https://github.com/getsentry/sentry-dotnet) at 6.3.0. <details> <summary>Release notes</summary> _Sourced from [Sentry.AspNetCore's releases](https://github.com/getsentry/sentry-dotnet/releases)._ ## 6.3.0 ### Features - The _Metrics_ APIs are now stable: removed `Experimental` from `SentrySdk`, `SentryOptions` and `IHub` ([#5023](getsentry/sentry-dotnet#5023)) - Report a new _Diagnostic_ (`SENTRY1001`) when a Metrics-API is invoked with an unsupported numeric type ([#4840](getsentry/sentry-dotnet#4840)) ### Fixes - Common tags such as `Environment` and `Release` and custom event processors are all now correctly applied to CaptureFeedback events ([#4942](getsentry/sentry-dotnet#4942)) - Include `Data` set via `ITransactionTracer` in `SentryTransaction` ([#4148](getsentry/sentry-dotnet#4148)) ### Dependencies - Bump Cocoa SDK from v9.5.0 to v9.7.0 ([#4958](getsentry/sentry-dotnet#4958), [#5015](getsentry/sentry-dotnet#5015)) - Bump CLI from v3.3.0 to v3.3.3 ([#5002](getsentry/sentry-dotnet#5002)) - Bump Java SDK from v8.34.1 to v8.35.0 ([#5017](getsentry/sentry-dotnet#5017)) - Bump Native SDK from v0.13.2 to v0.13.3 ([#5045](getsentry/sentry-dotnet#5045)) Commits viewable in [compare view](getsentry/sentry-dotnet@6.2.0...6.3.0). </details> Updated [Sentry.Extensions.Logging](https://github.com/getsentry/sentry-dotnet) from 6.2.0 to 6.3.0. <details> <summary>Release notes</summary> _Sourced from [Sentry.Extensions.Logging's releases](https://github.com/getsentry/sentry-dotnet/releases)._ ## 6.3.0 ### Features - The _Metrics_ APIs are now stable: removed `Experimental` from `SentrySdk`, `SentryOptions` and `IHub` ([#5023](getsentry/sentry-dotnet#5023)) - Report a new _Diagnostic_ (`SENTRY1001`) when a Metrics-API is invoked with an unsupported numeric type ([#4840](getsentry/sentry-dotnet#4840)) ### Fixes - Common tags such as `Environment` and `Release` and custom event processors are all now correctly applied to CaptureFeedback events ([#4942](getsentry/sentry-dotnet#4942)) - Include `Data` set via `ITransactionTracer` in `SentryTransaction` ([#4148](getsentry/sentry-dotnet#4148)) ### Dependencies - Bump Cocoa SDK from v9.5.0 to v9.7.0 ([#4958](getsentry/sentry-dotnet#4958), [#5015](getsentry/sentry-dotnet#5015)) - Bump CLI from v3.3.0 to v3.3.3 ([#5002](getsentry/sentry-dotnet#5002)) - Bump Java SDK from v8.34.1 to v8.35.0 ([#5017](getsentry/sentry-dotnet#5017)) - Bump Native SDK from v0.13.2 to v0.13.3 ([#5045](getsentry/sentry-dotnet#5045)) Commits viewable in [compare view](getsentry/sentry-dotnet@6.2.0...6.3.0). </details> Pinned [Sentry.Serilog](https://github.com/getsentry/sentry-dotnet) at 6.3.0. <details> <summary>Release notes</summary> _Sourced from [Sentry.Serilog's releases](https://github.com/getsentry/sentry-dotnet/releases)._ ## 6.3.0 ### Features - The _Metrics_ APIs are now stable: removed `Experimental` from `SentrySdk`, `SentryOptions` and `IHub` ([#5023](getsentry/sentry-dotnet#5023)) - Report a new _Diagnostic_ (`SENTRY1001`) when a Metrics-API is invoked with an unsupported numeric type ([#4840](getsentry/sentry-dotnet#4840)) ### Fixes - Common tags such as `Environment` and `Release` and custom event processors are all now correctly applied to CaptureFeedback events ([#4942](getsentry/sentry-dotnet#4942)) - Include `Data` set via `ITransactionTracer` in `SentryTransaction` ([#4148](getsentry/sentry-dotnet#4148)) ### Dependencies - Bump Cocoa SDK from v9.5.0 to v9.7.0 ([#4958](getsentry/sentry-dotnet#4958), [#5015](getsentry/sentry-dotnet#5015)) - Bump CLI from v3.3.0 to v3.3.3 ([#5002](getsentry/sentry-dotnet#5002)) - Bump Java SDK from v8.34.1 to v8.35.0 ([#5017](getsentry/sentry-dotnet#5017)) - Bump Native SDK from v0.13.2 to v0.13.3 ([#5045](getsentry/sentry-dotnet#5045)) Commits viewable in [compare view](getsentry/sentry-dotnet@6.2.0...6.3.0). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Summary
Remove "Experimental" properties and
[ExperimentalAttribute]from all Metrics APIs.Remarks
Changelog Entry
The Metrics APIs are now stable: removed
ExperimentalfromSentrySdk,SentryOptionsandIHubIssues
Closes #4921