feat(js): Move some configuration pages to "Best Practices"#9571
Merged
feat(js): Move some configuration pages to "Best Practices"#9571
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will increase total bundle size by 1.14kB ⬆️
|
Member
|
These pages shouldn't show up on the right, instead there should be a new menu item on the left called "Guides" and be sub items there |
58c98d0 to
827c62f
Compare
stephanie-anderson
approved these changes
Apr 4, 2024
Contributor
stephanie-anderson
left a comment
There was a problem hiding this comment.
Thanks, that looks really good!
Jeffreyhung
approved these changes
Apr 4, 2024
s1gr1d
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Apr 9, 2024
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Some pages in "Configuration" do not really contain configuration examples, but offer more of a "guideline". Users might search for usage examples for "Micro Frontends" or "Browser Extensions". Therefore, "Best Practices" are created. Talked with @HazAT and @mydea about this.