fix: Update docs for manual client creation#8495
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0d6e380 to
c36a693
Compare
lforst
approved these changes
Nov 15, 2023
Lms24
approved these changes
Nov 15, 2023
shanamatthews
approved these changes
Nov 16, 2023
Contributor
shanamatthews
left a comment
There was a problem hiding this comment.
Just some small phrasing tweaks, otherwise lgtm!
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Nov 16, 2023
While debugging something, figured it is good to have a test covering that this works as expected! See also: getsentry/sentry-docs#8495
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed these docs were actually incorrect, because you basically have to call
new Hub(client)- if you don't do this, integrations will not run, which will/may lead to unintended side effects. So updating this to just document this as "the" way to do this.While at this, I also updated this to specifically call out browser extensions, as that is a common thing we get requests for every now and then, and also point out that in addition you should not setup any global integrations in such a scenario.