Add Remix wizard instructions#7768
Merged
AbhiPrasad merged 14 commits intogetsentry:masterfrom Sep 19, 2023
Merged
Conversation
Add remix wizard, just moving over similar to next for now.
….mdx thank you! Co-authored-by: Onur Temizkan <onur@narval.co.uk>
….mdx Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
|
@onurtemizkan is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
manual-setup.|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AbhiPrasad
reviewed
Sep 7, 2023
src/platform-includes/getting-started-install/javascript.remix.mdx
Outdated
Show resolved
Hide resolved
lizokm
approved these changes
Sep 7, 2023
Contributor
lizokm
left a comment
There was a problem hiding this comment.
Made some suggestions, but otherwise this looks great!
src/platform-includes/getting-started-config/javascript.remix.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/getting-started-install/javascript.remix.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/getting-started-install/javascript.remix.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/getting-started-install/javascript.remix.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/getting-started-install/javascript.remix.mdx
Outdated
Show resolved
Hide resolved
Lms24
approved these changes
Sep 8, 2023
Member
Lms24
left a comment
There was a problem hiding this comment.
LGTM once the suggestions are applied, thanks Onur!
| }); | ||
| ``` | ||
|
|
||
| ## Custom Express Server |
Member
There was a problem hiding this comment.
l: I'd prefer this section and the v2 support section to switch places unless there's a concrete reason to have custom express server instructions come first(?) My thinking is that showing that we support v2 (future flags) is more important than custom servers.
….mdx Co-authored-by: Abhijeet Prasad <devabhiprasad@gmail.com>
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Co-authored-by: Liza Mock <lizka920@gmail.com>
Lms24
requested changes
Sep 8, 2023
Member
Lms24
left a comment
There was a problem hiding this comment.
Only requesting changes so we don't merge this until getsentry/sentry-wizard#433 is resolved. Let's only publish this once the wizard is fully ready.
Lms24
approved these changes
Sep 15, 2023
Member
Lms24
left a comment
There was a problem hiding this comment.
We released the wizard with the org/project fix yesterday so this is ready to go. Just one small suggestion but otherwise ready to 🚢
….mdx Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
shanamatthews
approved these changes
Sep 18, 2023
| }); | ||
| ``` | ||
|
|
||
| Initialize Sentry in your entry point for the server to capture exceptions and get performance metrics for your [`action`](https://remix.run/docs/en/v1/api/conventions#action) and [`loader`](https://remix.run/docs/en/v1/api/conventions#loader) functions. You can also initialize Sentry's database integrations, such as <Link to="/platforms/node/performance/database/opt-in/#prisma-orm-integration">Prisma</Link>, to get spans for your database calls. |
Contributor
There was a problem hiding this comment.
Looks like these links have moved
Suggested change
| Initialize Sentry in your entry point for the server to capture exceptions and get performance metrics for your [`action`](https://remix.run/docs/en/v1/api/conventions#action) and [`loader`](https://remix.run/docs/en/v1/api/conventions#loader) functions. You can also initialize Sentry's database integrations, such as <Link to="/platforms/node/performance/database/opt-in/#prisma-orm-integration">Prisma</Link>, to get spans for your database calls. | |
| Initialize Sentry in your entry point for the server to capture exceptions and get performance metrics for your [`action`](https://remix.run/docs/en/1.19.3/route/action) and [`loader`](https://remix.run/docs/en/1.19.3/route/loader) functions. You can also initialize Sentry's database integrations, such as <Link to="/platforms/node/performance/database/opt-in/#prisma-orm-integration">Prisma</Link>, to get spans for your database calls. |
onurtemizkan
commented
Sep 18, 2023
Co-authored-by: Onur Temizkan <onur@narval.co.uk>
AbhiPrasad
approved these changes
Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #7727
Continues: #7728
Can't push commits to the original PR, so opened a new one.