Skip to content

Update javascript.remix.mdx#7728

Closed
smeubank wants to merge 6 commits intomasterfrom
remix-wizard
Closed

Update javascript.remix.mdx#7728
smeubank wants to merge 6 commits intomasterfrom
remix-wizard

Conversation

@smeubank
Copy link
Contributor

@smeubank smeubank commented Sep 4, 2023

Add remix wizard, just moving over similar to next for now.

@smeubank
Update javascript.remix.mdx
ac14c50 
Add remix wizard, just moving over similar to next for now.
@vercel
Copy link

vercel bot commented Sep 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 0:57am

@smeubank smeubank linked an issue Sep 4, 2023 that may be closed by this pull request
Update Remix docs to use the wizard #7727
Closed
onurtemizkan
onurtemizkan reviewed Sep 4, 2023
View reviewed changes
smeubank and others added 2 commits September 5, 2023 17:31
@smeubank smeubank marked this pull request as ready for review September 5, 2023 15:33
shanamatthews
shanamatthews reviewed Sep 7, 2023
View reviewed changes
src/platform-includes/getting-started-install/javascript.remix.mdx

<Note>

If the setup through the wizard doesn't work for you, you can also <PlatformLink to="/manual-setup/">set up the SDK manually</PlatformLink>.
Copy link
Contributor

@shanamatthews shanamatthews Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link doesn't work. In the Next docs, this links to a separate manual setup page, but that page doesn't exist for Remix.

Along those lines, the sections that follow on the Remix Getting Started page have those manual setup instructions, which will likely be confusing for users since some of that configuration will already have been done by the wizard.

Could we split this page off into a manual configuration page too like Next does?

Copy link
Contributor Author

@smeubank smeubank Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes for sure, i was just trying to get something done faster :D

could you help me with splitting it off?

@smeubank @shanamatthews
Update src/platform-includes/getting-started-install/javascript.remix…
fe04485 
….mdx

Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
@onurtemizkan onurtemizkan mentioned this pull request Sep 7, 2023
Merged
@onurtemizkan
Copy link
Collaborator

onurtemizkan commented Sep 7, 2023 •
edited
Loading

@shanamatthews, I opened a new PR which also moves manual configuration content to manual-setup. #7768

@AbhiPrasad
Copy link
Contributor

AbhiPrasad commented Sep 7, 2023

@smeubank given Onur made the changes in #7768 I'm going to close this PR. We can review the rest of the changes there.

@AbhiPrasad AbhiPrasad closed this Sep 7, 2023
@AbhiPrasad AbhiPrasad deleted the remix-wizard branch September 19, 2023 14:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@onurtemizkan onurtemizkan onurtemizkan left review comments

+2 more reviewers

@shanamatthews shanamatthews shanamatthews left review comments

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Remix docs to use the wizard

4 participants

@smeubank @onurtemizkan @AbhiPrasad @shanamatthews