Skip to content

clarify that maxBreadcrumbs can be customized#4794

Merged
imatwawana merged 3 commits intomasterfrom
fix/clarify-max-breadcrumbs
Oct 7, 2022
Merged

clarify that maxBreadcrumbs can be customized#4794
imatwawana merged 3 commits intomasterfrom
fix/clarify-max-breadcrumbs

Conversation

@imatwawana
Copy link
Copy Markdown
Contributor

@imatwawana imatwawana commented Mar 3, 2022 •
edited by marandaneto
Loading

Fixes #4496

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 3, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/82862Dxy2aBiszxg4j347TGZDfAM
✅ Preview: https://sentry-docs-git-fix-clarify-max-breadcrumbs.sentry.dev

@imatwawana imatwawana linked an issue Mar 3, 2022 that may be closed by this pull request
maxBreadcrumbs limit unclear #4496
Closed
@imatwawana imatwawana removed a link to an issue Mar 3, 2022
maxBreadcrumbs limit unclear #4496
Closed
@imatwawana imatwawana requested a review from marandaneto March 3, 2022 20:45
@imatwawana
Copy link
Copy Markdown
Contributor Author

imatwawana commented Mar 3, 2022

@liamjones - I haven't linked this your issue to the PR, since this might not be the only PR associated with it, but wanted you to be able to review the wording here and see if it's clearer to you.

@liamjones
Copy link
Copy Markdown
Contributor

liamjones commented Mar 4, 2022

@imatwawana Yep, that's helpful! I wasn't aware of the 1MB limit before this...

marandaneto
marandaneto reviewed Mar 4, 2022
View reviewed changes
@imatwawana @marandaneto
remove reference to 1MB to avoid content going out of date
4043a62 
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
@imatwawana imatwawana marked this pull request as draft March 4, 2022 14:49
@imatwawana
Copy link
Copy Markdown
Contributor Author

imatwawana commented Mar 4, 2022

Converting this to draft until we've figured out exactly what changes need to be made in source code documentation.

@marandaneto marandaneto mentioned this pull request Mar 8, 2022
Closed
@marandaneto
Copy link
Copy Markdown
Contributor

marandaneto commented Mar 8, 2022

Converting this to draft until we've figured out exactly what changes need to be made in source code documentation.

This can be merged after getsentry/sentry-javascript#4693 gets done and released.

@Lms24 Lms24 marked this pull request as ready for review October 5, 2022 08:18
Lms24
Lms24 approved these changes Oct 5, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getsentry/sentry-javascript#4693 was resolved so we can merge this when we cut the next JS SDK release

@imatwawana
Copy link
Copy Markdown
Contributor Author

imatwawana commented Oct 5, 2022

getsentry/sentry-javascript#4693 was resolved so we can merge this when we cut the next JS SDK release

Thanks, @Lms24! Can you drop a note on this PR when that happens?

@Lms24
Copy link
Copy Markdown
Member

Lms24 commented Oct 5, 2022

@imatwawana sure, will do

@AbhiPrasad
Copy link
Copy Markdown
Contributor

AbhiPrasad commented Oct 6, 2022 •
edited
Loading

Released with https://github.com/getsentry/sentry-javascript/releases/tag/7.14.2 - we can now merge!

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 7, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-docs ✅ Ready (Inspect) Visit Preview Oct 7, 2022 at 2:14PM (UTC)

@imatwawana imatwawana merged commit 60671c9 into master Oct 7, 2022
@imatwawana imatwawana deleted the fix/clarify-max-breadcrumbs branch October 7, 2022 14:36
lforst pushed a commit that referenced this pull request Oct 10, 2022
@imatwawana @marandaneto
clarify that maxBreadcrumbs can be customized (#4794)
a7dd2b8 
* clarified that maxbreadcrumbs can be customized

* remove reference to 1MB to avoid content going out of date

Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>

* retrigger stuck check

Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Lms24 Lms24 Lms24 approved these changes

+1 more reviewer

@marandaneto marandaneto marandaneto left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

maxBreadcrumbs limit unclear

5 participants

@imatwawana @liamjones @marandaneto @Lms24 @AbhiPrasad