fix(native): Update Trace Boundaries documentation #14201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 861.38kB (4.08%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
JoshuaMoelans
commented
Jun 30, 2025
🚨 BugBot couldn't runBugBot is experiencing high demand right now. Try again in a few minutes by commenting "bugbot run" (requestId: serverGenReqId_557d2e7f-5175-46c3-ae2d-2475bd3d6627). |
supervacuus
approved these changes
Jul 1, 2025
Collaborator
supervacuus
left a comment
There was a problem hiding this comment.
Would now keep sentry_set_trace() and s/sentry_generate_trace/sentry_regenerate_trace
supervacuus
reviewed
Jul 1, 2025
supervacuus
approved these changes
Jul 1, 2025
Collaborator
supervacuus
left a comment
There was a problem hiding this comment.
minor nit, but otherwise good to go.
Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
supervacuus
approved these changes
Jul 1, 2025
bitsandfoxes
pushed a commit
that referenced
this pull request
Jul 3, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> [Current docs](https://docs.sentry.io/platforms/native/tracing/instrumentation/custom-instrumentation/) [Updated docs (vercel preview)](https://sentry-docs-git-joshua-settraceclarification.sentry.dev/platforms/native/tracing/instrumentation/custom-instrumentation/#trace-boundaries) ## DESCRIBE YOUR PR Adding some more detailed explanation on the Native handling of trace boundaries & when/how to set a new trace. Only merge after getsentry/sentry-native#1293 ToDo - [x] add better explanation - [x] ? provide example of generating new trace/span ID? - we don't really have an API for this (yet), but we could reuse `sentry_uuid_t uid = sentry_uuid_new_v4();`? -> added in getsentry/sentry-native#1293 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ --------- Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current docs
Updated docs (vercel preview)
DESCRIBE YOUR PR
Adding some more detailed explanation on the Native handling of trace boundaries & when/how to set a new trace.
Only merge after getsentry/sentry-native#1293
ToDo
sentry_uuid_t uid = sentry_uuid_new_v4();?-> added in feat: add
sentry_regenerate_trace()sentry-native#1293IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.