Skip to content

fix(apple): Missing semicolons in objc config snippets#13578

Merged
kahest merged 1 commit intomasterfrom
kahest/apple-fix-objc-typo
May 2, 2025
Merged

fix(apple): Missing semicolons in objc config snippets#13578
kahest merged 1 commit intomasterfrom
kahest/apple-fix-objc-typo

Conversation

@kahest
Copy link
Copy Markdown
Contributor

@kahest kahest commented May 2, 2025

DESCRIBE YOUR PR

Add missing semicolons in objc config snippets

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@kahest kahest requested a review from philipphofmann May 2, 2025 13:20
@vercel
Copy link
Copy Markdown

vercel bot commented May 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 1:34pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) May 2, 2025 1:34pm
develop-docs ⬜️ Ignored (Inspect) May 2, 2025 1:34pm

@kahest kahest requested a review from philprime May 2, 2025 13:20
@codecov
Copy link
Copy Markdown

codecov bot commented May 2, 2025 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.15MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/w3CiaJmgtl_Gwz0sHnPyy/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/w3CiaJmgtl_Gwz0sHnPyy/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/W2o5uhFbewGooRo3jisu0/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/W2o5uhFbewGooRo3jisu0/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

philprime
philprime approved these changes May 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@kahest kahest merged commit 88896e0 into master May 2, 2025
11 checks passed
@kahest kahest deleted the kahest/apple-fix-objc-typo branch May 2, 2025 14:23
codyde added a commit that referenced this pull request May 5, 2025
@codyde
Merge branch 'master' of https://github.com/getsentry/sentry-docs
fa1b5dc 
* 'master' of https://github.com/getsentry/sentry-docs:
  Fix small typo (#13570)
  Update trace explorer doc for GA (#13560)
  feat(cloudflare): Add jsonc instructions for sourcemaps upload (#13572)
  fix(apple): Missing semicolons in objc config snippets (#13578)
  feat(godot): Enriching events with scene tree data (#13531)
  feat(apple): Troubleshooting for subclass error (#13509)
  Make the API Design doc a bit more consistent (#13511)
  docs(js): Remove outdated/misleading warning (#13484)
  Refine SDK behavior docs for logs to make buffering more clear (#13573)
  fix(spike protection): correct floor calculation explanation (#13556)
  ref(docs): rm session health from early adopter (#13571)
  Bump API schema to 8c0365cd (#13564)
  Updating MCP docs with Video + Claude steps  (#13563)
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@philprime philprime philprime approved these changes

@philipphofmann philipphofmann Awaiting requested review from philipphofmann

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kahest @philprime