fix(solidstart): Remove outdated sentrySolidStartVite option#12962
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
s1gr1d
reviewed
Mar 10, 2025
| `SENTRY_AUTH_TOKEN` environment variable or have an `.env.sentry-build-plugin` file in the working directory when | ||
| building your project. | ||
| To upload source maps, configure an auth token. Auth tokens can be passed to `withSentry` explicitly with the `authToken` | ||
| option. You can also use the `SENTRY_AUTH_TOKEN` environment variable or have an `.env.sentry-build-plugin` file in the |
Member
There was a problem hiding this comment.
Just a general question: Does the naming of this file have any impact? From how I read it here it seems like the naming is important. But as far as I know only the naming of the env variable is important 🤔
Member
Author
There was a problem hiding this comment.
Depends on how your framework handles env files I guess. If it doesn't then this naming convention is picked up by the bundler plugin. I'd say having the exact name solves a bunch of hassles.
Co-authored-by: Sigrid Huemer <32902192+s1gr1d@users.noreply.github.com>
s1gr1d
approved these changes
Mar 10, 2025
codyde
added a commit
that referenced
this pull request
Mar 13, 2025
…om/getsentry/sentry-docs into codyde/javascript-tracing-refactor * 'codyde/javascript-tracing-refactor' of https://github.com/getsentry/sentry-docs: (104 commits) Update docs/concepts/key-terms/tracing/index.mdx Update docs/concepts/key-terms/tracing/index.mdx Update docs/concepts/key-terms/tracing/index.mdx Update docs/concepts/key-terms/tracing/index.mdx Update docs/concepts/key-terms/tracing/index.mdx Update docs/concepts/key-terms/tracing/index.mdx Update index.mdx (#12928) docs(self-hosted): monitor self-hosted instance (#12660) fix(feedback): rm per-feedback attach limit (#12968) fix(404): php integrations (#12966) docs(js): Update stale reference (#12964) fix(solidstart): Remove outdated `sentrySolidStartVite` option (#12962) chore(sandbox): change sandbox link (#12814) feat: Godot debug symbols guide (#12843) fix 404s (#12961) Fix SDK getting started pages (onboarding options) (#12960) fix(platform): Update onboarding options on tab switch (#12913) Fix Apollo links (#12952) chore(Android): Update docs to match actual SDK behavior (#12954) docs(js): Add example docs for non-HTTP protocols (#12933) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
The docs for Solid Start still had a mention to
sentrySolidStartVitewhich we removed with v9.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES