Deprecated enable_tracing option in Python docs.#12439
Merged
stephanie-anderson merged 1 commit intomasterfrom Feb 5, 2025
Merged
Deprecated enable_tracing option in Python docs.#12439stephanie-anderson merged 1 commit intomasterfrom
enable_tracing option in Python docs.#12439stephanie-anderson merged 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
coolguyzone
approved these changes
Jan 23, 2025
Contributor
coolguyzone
left a comment
There was a problem hiding this comment.
Thanks for updating, looks good.
Contributor
Author
|
Thanks for reviewing @coolguyzone, I will merge this once the new version of the SDK with the deprecation has been released. |
sentrivana
approved these changes
Jan 27, 2025
stephanie-anderson
approved these changes
Feb 5, 2025
kid-alan
reviewed
Feb 12, 2025
| enable_tracing=True, | ||
| # Set traces_sample_rate to 1.0 to capture 100% | ||
| # of transactions for tracing. | ||
| tracees_sample_rate=1.0, |
There was a problem hiding this comment.
@antonpirker Hello! Noticed this PR introduced a typo.
There is a doubled "ee"
tracees_sample_rate # current
traces_sample_rate # should be
Contributor
There was a problem hiding this comment.
Fix should be up soon. Thanks again for noticing.
vperron
added a commit
to gip-inclusion/data-inclusion
that referenced
this pull request
Feb 26, 2025
There was a SENTRY_ENABLE_TRACING parameter introduced in 65a4d4e, but it is now removed from the Sentry SDK documentation. The correct configuration is now the traces_sample_rate setting: getsentry/sentry-docs#12439 It's a little bit disappointing to notice though that having the traces enabled since a long time didn't help getting the ooutgoing HTTP requests timings, as those are not supported in airflow-sentry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
The option
enable_tracinghas been deprecated, so update the docs to not use it in code snippets and mark it as deprecated.Preview: https://sentry-docs-git-antonpirker-pythondeprecate-enable-tracing.sentry.dev/platforms/python/configuration/options#enable-tracing
Fixes #12417
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES