Skip to content

feat(js): Update docs for custom integrations#10150

Merged
mydea merged 3 commits intomasterfrom
fn/js-custom-integrations
May 27, 2024
Merged

feat(js): Update docs for custom integrations#10150
mydea merged 3 commits intomasterfrom
fn/js-custom-integrations

Conversation

@mydea
Copy link
Copy Markdown
Member

@mydea mydea commented May 27, 2024 •
edited
Loading

This updates the JS custom integration docs to show which APIs we support.

@mydea mydea requested review from Lms24, andreiborza and lforst May 27, 2024 07:52
@mydea mydea self-assigned this May 27, 2024
@vercel
Copy link
Copy Markdown

vercel bot commented May 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 9:44am

@codecov
Copy link
Copy Markdown

codecov bot commented May 27, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 12 bytes ⬇️

Bundle name Size Change
sentry-docs-server 7.42MB 3 bytes ⬇️
sentry-docs-edge-server 461.86kB 3 bytes ⬇️
sentry-docs-client 6.18MB 6 bytes ⬇️

@mydea mydea mentioned this pull request May 27, 2024
Merged
Lms24
Lms24 approved these changes May 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Lms24 Lms24 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! Should we also document preprocessEvent and afterAllSetup?

(doesn't have to happen in this PR! We can also omit it)

@mydea
Copy link
Copy Markdown
Member Author

mydea commented May 27, 2024

I decided to keep it simple for now, not showing preprocessEvent and afterAllSetup because it probably should not be used in user-land (we can always add it later if needed).

I decided to keep it simple for now, not showing preprocessEvent and afterAllSetup because it probably should not be used in user-land (we can always add it later if needed).

No strong feelings on this though, also happy to add this too 🤔

@andreiborza
Copy link
Copy Markdown
Member

andreiborza commented May 27, 2024

I decided to keep it simple for now, not showing preprocessEvent and afterAllSetup because it probably should not be used in user-land (we can always add it later if needed).

I decided to keep it simple for now, not showing preprocessEvent and afterAllSetup because it probably should not be used in user-land (we can always add it later if needed).

No strong feelings on this though, also happy to add this too 🤔

I'm personally interested in afterAllSetup since I'm using it atm :)

@mydea
Copy link
Copy Markdown
Member Author

mydea commented May 27, 2024

I'm personally interested in afterAllSetup since I'm using it atm :)

haha, good point - I'll simply add all methods then 👍

mydea and others added 2 commits May 27, 2024 11:09
@mydea
add preprocessEvent and afterAllSetup to docs
f81aa0a
@mydea @andreiborza
Update docs/platforms/javascript/common/configuration/integrations/cu…
8acd9e8 
…stom.mdx

Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
@mydea
Copy link
Copy Markdown
Member Author

mydea commented May 27, 2024

Updated this to now document all methods.

andreiborza
andreiborza approved these changes May 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mydea mydea merged commit 8c34620 into master May 27, 2024
@mydea mydea deleted the fn/js-custom-integrations branch May 27, 2024 09:45
matejminar pushed a commit that referenced this pull request Jun 6, 2024
@mydea @andreiborza @matejminar
feat(js): Update docs for custom integrations (#10150)
5aecd63 

---------

Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
a-hariti pushed a commit that referenced this pull request Jun 8, 2024
@mydea @andreiborza @a-hariti
feat(js): Update docs for custom integrations (#10150)
7214bf4 

---------

Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@andreiborza andreiborza andreiborza approved these changes

@lforst lforst Awaiting requested review from lforst

Assignees

@mydea mydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mydea @andreiborza @Lms24