feat(http): add http.server.request.time_in_queue attribute#267
Merged
feat(http): add http.server.request.time_in_queue attribute#267
Conversation
Adds the `http.server.request.time_in_queue` semantic convention attribute to capture the time (in milliseconds) a request spent waiting in the server queue before processing began. This attribute is populated from the `X-Request-Start` header set by reverse proxies (Nginx, HAProxy, Heroku router, etc.) and first introduced in sentry-ruby: getsentry/sentry-ruby#2838 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
mjq
requested changes
Feb 24, 2026
Member
mjq
left a comment
There was a problem hiding this comment.
Looks good to me, but you'll have to run yarn generate && yarn format to generate and format code and docs for your change before CI will pass.
…st.time_in_queue Generate TypeScript and Python attribute definitions including type exports, metadata entries, and TypedDict annotations. Co-Authored-By: Claude <noreply@anthropic.com>
sl0thentr0py
approved these changes
Feb 25, 2026
ericapisani
added a commit
that referenced
this pull request
Mar 4, 2026
Add a changelog field to attribute JSON files that tracks how each attribute has changed across sentry-conventions release versions. This includes the schema extension, a generation script that derives changelog entries from git tags and commit history, updates to both TypeScript and Python code generators, docs UI rendering, and validation tests. Co-Authored-By: Claude <noreply@anthropic.com> * style: Fix biome formatting and lint errors Run biome formatter across all JSON model files to inline short arrays, and replace non-null assertions with optional chaining or type casts to satisfy biome's noNonNullAssertion rule. Co-Authored-By: Claude <noreply@anthropic.com> * feat: Merge changelogs instead of replacing on re-generation Preserve manually added descriptions, hand-curated entries, and other manual edits when re-running the changelog generation script. Previously the script would completely replace existing changelog data on every run. Add mergeChangelogs() that indexes by version, unions PR numbers, preserves existing descriptions, keeps manual-only entries, and re-sorts newest-first. Add unit tests covering edge cases. Co-Authored-By: Claude <noreply@anthropic.com> * feat: Add 'next' version support and changelog promotion on release Support unreleased changes tracked as "next" entries in attribute changelogs. When a new release tag is created, "next" entries are automatically promoted to the new version while preserving manually-added descriptions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: Display changelog of attributes with 'next' version support Show the attribute changelog in the AttributeCard component, including entries with version 'next' (displayed without a 'v' prefix). Update compareVersions to handle 'next' correctly and export it for reuse in tests, removing the duplicate implementation. Co-Authored-By: Claude <noreply@anthropic.com> * ref(changelog): Simplify sort comparator and add perf TODO Remove redundant 'next' guards in the sort comparator — compareVersions already handles 'next' correctly, making those checks dead code. Add a TODO comment noting the O(files × versions) git subprocess cost and suggesting a future batch approach using `git diff --name-only`. Co-Authored-By: Claude <noreply@anthropic.com> * fix(lint): Replace delete operator with undefined assignment Biome's noDelete lint rule flags the delete operator for performance. Since changelog is an optional field and JSON.stringify omits undefined values, the behavior is identical. Co-Authored-By: Claude <noreply@anthropic.com> * feat(changelog): Add 'next' version changelog entries for attributes Add changelog entries with version 'next' to attributes modified by PRs #261, #264, #265, #266, and #267. This tracks upcoming changes for the next release across AI, tool, and deployment environment attributes. Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the
http.server.request.time_in_queuesemantic convention attribute to capture the time (in milliseconds) a request spent waiting in the server queue before processing began.This attribute is populated from the
X-Request-Startheader set by reverse proxies (Nginx, HAProxy, Heroku router, etc.) and first introduced in sentry-ruby: getsentry/sentry-ruby#2838PR Checklist
yarn testand verified that the tests pass.yarn generate && yarn formatto generate and format code and docs.If an attribute was added:
nextjs.function_id, notfunction_id)pii(i.e.maybeortrue. Usefalseonly for values that should never be scrubbed such as IDs)If an attribute was deprecated: