fix(replay): correct file type for SentrySessionReplayHybridSDK.m in pbxproj#7911
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7911 +/- ##
=============================================
- Coverage 85.541% 85.476% -0.066%
=============================================
Files 487 488 +1
Lines 29672 29690 +18
Branches 12881 12894 +13
=============================================
- Hits 25382 25378 -4
- Misses 4241 4262 +21
- Partials 49 50 +1 see 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
10 tasks
NinjaLikesCheez
approved these changes
May 19, 2026
philprime
approved these changes
May 19, 2026
📲 Install BuildsiOS
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c67ced3 | 1223.22 ms | 1256.15 ms | 32.93 ms |
| 44b7b59 | 1211.91 ms | 1248.90 ms | 36.99 ms |
| ffb6adc | 1218.60 ms | 1247.47 ms | 28.87 ms |
| 37fd1b7 | 1227.56 ms | 1262.45 ms | 34.89 ms |
| 787537a | 1218.35 ms | 1251.72 ms | 33.38 ms |
| 92bcc8f | 1233.43 ms | 1270.20 ms | 36.77 ms |
| 65c13c5 | 1234.47 ms | 1263.10 ms | 28.63 ms |
| 53097d6 | 1218.02 ms | 1251.70 ms | 33.68 ms |
| 8180609 | 1214.67 ms | 1243.36 ms | 28.69 ms |
| ce900e7 | 1212.40 ms | 1244.57 ms | 32.18 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c67ced3 | 24.14 KiB | 1.16 MiB | 1.13 MiB |
| 44b7b59 | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| ffb6adc | 24.14 KiB | 1.15 MiB | 1.12 MiB |
| 37fd1b7 | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| 787537a | 24.14 KiB | 1.15 MiB | 1.12 MiB |
| 92bcc8f | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| 65c13c5 | 24.14 KiB | 1.15 MiB | 1.12 MiB |
| 53097d6 | 24.14 KiB | 1.16 MiB | 1.13 MiB |
| 8180609 | 24.14 KiB | 1.16 MiB | 1.13 MiB |
| ce900e7 | 24.14 KiB | 1.15 MiB | 1.13 MiB |
alwx
added a commit
to getsentry/sentry-react-native
that referenced
this pull request
May 26, 2026
Adds a new opt-in path in RNSentry.podspec: when `SENTRY_USE_SPM=1` is set in the environment before `pod install`, RNSentry pulls `Sentry` from the sentry-cocoa SPM package (as a binary xcframework) instead of from the Sentry CocoaPods source build. Default behavior is unchanged. Existing users on any React Native version keep their current CocoaPods-based consumption with no action required. The opt-in path requires React Native >= 0.75 because it uses the `SPMManager` singleton defined in `react-native/scripts/cocoapods/spm.rb`, which is loaded transitively from the Podfile via `react_native_pods.rb`. This is the first step of the broader SPM migration tracked at #5780. It unblocks experimentation with binary-framework consumption of sentry-cocoa while keeping CocoaPods as the production default. Two known caveats for users opting in today: 1. The Sentry xcframework in sentry-cocoa 9.13.0 and earlier is missing the `SentrySessionReplayHybridSDK` symbol due to a packaging bug (getsentry/sentry-cocoa#7911). Apps that use Session Replay will fail to link until that fix ships in a sentry-cocoa release. Apps not using Session Replay are unaffected. 2. `SentrySwizzle.h` must be imported via framework-style (`<Sentry/...>`) rather than quote-style when the xcframework is the consumption path — already handled by #6175 (in this same release). Verified locally: - Default `pod install` (no env var) — `** BUILD SUCCEEDED **` on the RN sample, identical to the pre-change state. - `SENTRY_USE_SPM=1 pod install` — Sentry no longer in Podfile.lock, `XCRemoteSwiftPackageReference "sentry-cocoa"` injected into the Xcode project, [SPM] log lines confirm the helper ran correctly. Refs: #5780, #6170
alwx
added a commit
to getsentry/sentry-react-native
that referenced
this pull request
May 27, 2026
…er (#6182) * feat(ios): opt-in consumption of sentry-cocoa via Swift Package Manager Adds a new opt-in path in RNSentry.podspec: when `SENTRY_USE_SPM=1` is set in the environment before `pod install`, RNSentry pulls `Sentry` from the sentry-cocoa SPM package (as a binary xcframework) instead of from the Sentry CocoaPods source build. Default behavior is unchanged. Existing users on any React Native version keep their current CocoaPods-based consumption with no action required. The opt-in path requires React Native >= 0.75 because it uses the `SPMManager` singleton defined in `react-native/scripts/cocoapods/spm.rb`, which is loaded transitively from the Podfile via `react_native_pods.rb`. This is the first step of the broader SPM migration tracked at #5780. It unblocks experimentation with binary-framework consumption of sentry-cocoa while keeping CocoaPods as the production default. Two known caveats for users opting in today: 1. The Sentry xcframework in sentry-cocoa 9.13.0 and earlier is missing the `SentrySessionReplayHybridSDK` symbol due to a packaging bug (getsentry/sentry-cocoa#7911). Apps that use Session Replay will fail to link until that fix ships in a sentry-cocoa release. Apps not using Session Replay are unaffected. 2. `SentrySwizzle.h` must be imported via framework-style (`<Sentry/...>`) rather than quote-style when the xcframework is the consumption path — already handled by #6175 (in this same release). Verified locally: - Default `pod install` (no env var) — `** BUILD SUCCEEDED **` on the RN sample, identical to the pre-change state. - `SENTRY_USE_SPM=1 pod install` — Sentry no longer in Podfile.lock, `XCRemoteSwiftPackageReference "sentry-cocoa"` injected into the Xcode project, [SPM] log lines confirm the helper ran correctly. Refs: #5780, #6170 * version fix * update-cocoa.sh fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
The file was declared with
lastKnownFileType = sourcecode.c.hinstead ofsourcecode.c.objc, causing Xcode to treat it as a header. As a result the implementation was silently skipped during compilation of the xcframework variants (Sentry, Sentry-Dynamic, …), and consumers of the published xcframework hitUndefined symbol: _OBJC_CLASS_$_SentrySessionReplayHybridSDKat link time.💡 Motivation and Context
We need that for sentry-react-native (getsentry/sentry-react-native#5780)
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.#skip-changelog