Skip to content

fix: Use cocoapod resource_bundles for PrivacyInfo#3651

Merged
brustolin merged 3 commits intomainfrom
fix/privacyinfo-cocoa
Feb 19, 2024
Merged

fix: Use cocoapod resource_bundles for PrivacyInfo#3651
brustolin merged 3 commits intomainfrom
fix/privacyinfo-cocoa

Conversation

@brustolin
Copy link
Copy Markdown
Contributor

📜 Description

Changed the inclusion of PrivacyInfo.xcprivacy to resource_bundles for cocoapod to avoid resource name collision when the user uses cocoapod as static library.

💡 Motivation and Context

Fixes getsentry/sentry-react-native#3599

💚 How did you test it?

Sample

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Copy Markdown
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
@brustolin brustolin merged commit 3a2e953 into main Feb 19, 2024
@brustolin brustolin deleted the fix/privacyinfo-cocoa branch February 19, 2024 12:17
airtelnitesh pushed a commit to airtelnitesh/sentry-cocoa that referenced this pull request Apr 12, 2024
Changed the inclusion of PrivacyInfo.xcprivacy to resource_bundles for cocoapod to avoid resource name collision when the user uses cocoapod as static library.

Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
(cherry picked from commit 3a2e953)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple commands produce PrivacyInfo.xcprivacy

2 participants