misc: Show project and organization when using info log level#670
Merged
kamilogorek merged 2 commits intomasterfrom Mar 6, 2020
Merged
misc: Show project and organization when using info log level#670kamilogorek merged 2 commits intomasterfrom
kamilogorek merged 2 commits intomasterfrom
Conversation
8785ea4 to
180ff5f
Compare
HazAT
reviewed
Mar 4, 2020
Member
HazAT
left a comment
There was a problem hiding this comment.
I have no idea about the codebase and I suppose there is currently no better way of doing this right?
The fact that this is duplicated several times
info!(
"Issuing a command for Organization: {} Project: {}",
org, project
);
makes me sad :(
Contributor
Author
|
Every command has it's own |
szokeasaurusrex
added a commit
that referenced
this pull request
May 6, 2025
These appear to have been originally added in #670; however, we have not adopted these info logs consistently across all of our commands, and we believe they are likely not very useful. Since some of these commands are going to be modified to accept multiple projects, the info log would anyways need to be reworked if we were to keep it; however, it is simpler just to get rid of the log for now.
szokeasaurusrex
added a commit
that referenced
this pull request
May 6, 2025
These appear to have been originally added in #670; however, we have not adopted these info logs consistently across all of our commands, and we believe they are likely not very useful. Since some of these commands are going to be modified to accept multiple projects, the info log would anyways need to be reworked if we were to keep it; however, it is simpler just to get rid of the log for now.
szokeasaurusrex
added a commit
that referenced
this pull request
May 7, 2025
These appear to have been originally added in #670; however, we have not adopted these info logs consistently across all of our commands, and we believe they are likely not very useful. Since some of these commands are going to be modified to accept multiple projects, the info log would anyways need to be reworked if we were to keep it; however, it is simpler just to get rid of the log for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.