feat: Use a connection pool for curl to avoid TLS and retry on more errors#489
Merged
feat: Use a connection pool for curl to avoid TLS and retry on more errors#489
Conversation
We're pretty confident that curl handles stashed into TLS causes all kinds of mischief on thread shutdown which sometimes might even cause a segfault. This instead stashes the handles into an r2d2 connection pool. This also removes the manual cleanup now which we added as a workaround because TLS did not trigger dtors.
Contributor
Author
|
I'm thinking that instead of using a lazy static here it would be safer to create it in the main function. That would also cause it to actually clean up. |
jan-auer
approved these changes
Feb 25, 2019
Member
|
Agreed, allocating somewhere around main and passing it down would be nicer than a lazy_static Mutex Option :) |
szokeasaurusrex
added a commit
that referenced
this pull request
Feb 20, 2024
We removed Api::reset way back in #489. We should delete this comment that continues to reference Api::reset, since it is clearly inaccurate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're pretty confident that curl handles stashed into TLS causes all
kinds of mischief on thread shutdown which sometimes might even cause a
segfault. This instead stashes the handles into an r2d2 connection
pool.
This PR also adds more retries for common network issues we encounter.