fix: Safer asset catalog reader for liquid glass#2771
Merged
noahsmartin merged 1 commit intomasterfrom Sep 19, 2025
Merged
Conversation
trevor-e
approved these changes
Sep 18, 2025
7e2d659 to
f50413e
Compare
szokeasaurusrex
approved these changes
Sep 19, 2025
Member
szokeasaurusrex
left a comment
There was a problem hiding this comment.
I don't fully understand why this is needed, but the change seems reasonable from my understanding of it (primarily, that we handle missing values instead of crashing)
runningcode
pushed a commit
that referenced
this pull request
Sep 19, 2025
While we still have this in two codebases we need to copy over the emerge change from: EmergeTools/emerge#11525
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While we still have this in two codebases we need to copy over the emerge change from: https://github.com/EmergeTools/emerge/pull/11525