ci: Run lint action on all target operating systems#2360
Merged
szokeasaurusrex merged 2 commits intomasterfrom Mar 25, 2025
Merged
ci: Run lint action on all target operating systems#2360szokeasaurusrex merged 2 commits intomasterfrom
szokeasaurusrex merged 2 commits intomasterfrom
Conversation
1a5d671 to
91a63b9
Compare
Unblocks #2360 by avoiding `unnecessary_wraps`
Sentry CLI contains platform-dependent code. Therefore, to ensure we catch all linter errors, we need to run `cargo clippy` against all targets.
szokeasaurusrex
added a commit
that referenced
this pull request
Mar 24, 2025
Don't compile the function at all for Windows (this avoids `unnecessary_wraps` lint on Windows). Partially unblocks #2360.
91a63b9 to
8cb7822
Compare
This was referenced Mar 24, 2025
loewenheim
approved these changes
Mar 25, 2025
szokeasaurusrex
added a commit
that referenced
this pull request
Mar 25, 2025
Unblocks #2360 by avoiding `unnecessary_wraps`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sentry CLI contains platform-dependent code. Therefore, to ensure we catch all linter errors, we need to run
cargo clippyagainst all targets.