ref: Prevent @vercel/nft and similar tools from including binary file in their bundles#1207
Merged
kamilogorek merged 1 commit intomasterfrom Apr 26, 2022
Merged
ref: Prevent @vercel/nft and similar tools from including binary file in their bundles#1207kamilogorek merged 1 commit intomasterfrom
kamilogorek merged 1 commit intomasterfrom
Conversation
… in their bundles
lforst
approved these changes
Apr 26, 2022
kamilogorek
added a commit
that referenced
this pull request
Apr 26, 2022
… in their bundles (#1207)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
evalusage is a workaround for@vercel/nftdetecting the binary itself as the hard dependency and effectively always including it in the bundle, which is not what we want.ref: getsentry/sentry-javascript#3865
ref: vercel/nft#203