ref: Dont run install script using node binary#1151
Merged
kamilogorek merged 1 commit intomasterfrom Mar 17, 2022
Merged
Conversation
AbhiPrasad
approved these changes
Mar 17, 2022
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Good change. We should enforce this in the SDKs as well.
|
This PR broke the install of @sentry/cli under Windows (on GitHub Actions) for us:
|
|
I'm having the same issue on Windows, it can no longer be installed.
|
Contributor
Author
|
Oh, excuse me. Fixing now (although gh has some issues so might not be able to release atm) |
kamilogorek
added a commit
that referenced
this pull request
Mar 17, 2022
Contributor
Author
|
@beheh @victoriaNine released patch in |
|
Perfect, working again. Thanks for the quick fix 🙌 |
kamilogorek
added a commit
that referenced
this pull request
Mar 31, 2022
kamilogorek
added a commit
that referenced
this pull request
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of relying on some random
node, which is decided by thenpmon runtime (eg.npmadds everything fromnode_modules/.binto$PATHfor its lifecycle-scripts), let#!/usr/bin/env nodefrom scripts itself decide../install/script.jshas all-xchmod flags set correctly, so it won't be a problem executing it.