fix(explore): Insert group bys before visualizes if possible #97923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding a group by from the toolbar, we want them to appear before the visualizes when the existing aggregate fields are sorted with group bys first then visualizes.
narsaynorath
approved these changes
Aug 15, 2025
priscilawebdev
pushed a commit
that referenced
this pull request
Aug 25, 2025
When adding a group by from the toolbar, we want them to appear before the visualizes when the existing aggregate fields are sorted with group bys first then visualizes. Closes EXP-380
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 26, 2025
When adding a group by from the toolbar, we want them to appear before the visualizes when the existing aggregate fields are sorted with group bys first then visualizes. Closes EXP-380
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a group by from the toolbar, we want them to appear before the visualizes when the existing aggregate fields are sorted with group bys first then visualizes.
Closes EXP-380