feat(otlp): Collapse Trace Waterfall spans based on span name #97706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More parts of the trace waterfall need access to the organization.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Abdkhan14
approved these changes
Aug 14, 2025
Contributor
Abdkhan14
left a comment
There was a problem hiding this comment.
Lets try this out, the organization thing is a bit icky but it's for a flag and we'll get rid of it eventually so it doesn't hurt as much
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
priscilawebdev
pushed a commit
that referenced
this pull request
Aug 25, 2025
If the user has OTel-friendly UI enabled, update the logic that figures out which sibling spans should be collapsed. Since the _labels_ for the spans use the op and name, the collapsing logic also needs to use op and name, rather than op and description. Unfortunately, in order to check the feature flag, I had to pass `organization` through _everywhere_ in the `TraceTree` class. There are so many call sites, and passing an `organization` in the options is pattern that already exists, so I followed it here, too. One alternative is to do a shenanigan, and to fill the `description` field of a span with the name, and let everything else work the same, but that feels like it'll just cause more confusion.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 26, 2025
If the user has OTel-friendly UI enabled, update the logic that figures out which sibling spans should be collapsed. Since the _labels_ for the spans use the op and name, the collapsing logic also needs to use op and name, rather than op and description. Unfortunately, in order to check the feature flag, I had to pass `organization` through _everywhere_ in the `TraceTree` class. There are so many call sites, and passing an `organization` in the options is pattern that already exists, so I followed it here, too. One alternative is to do a shenanigan, and to fill the `description` field of a span with the name, and let everything else work the same, but that feels like it'll just cause more confusion.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has OTel-friendly UI enabled, update the logic that figures out which sibling spans should be collapsed. Since the labels for the spans use the op and name, the collapsing logic also needs to use op and name, rather than op and description.
Unfortunately, in order to check the feature flag, I had to pass
organizationthrough everywhere in theTraceTreeclass. There are so many call sites, and passing anorganizationin the options is pattern that already exists, so I followed it here, too.One alternative is to do a shenanigan, and to fill the
descriptionfield of a span with the name, and let everything else work the same, but that feels like it'll just cause more confusion.