Skip to content

aci(feat): Use propagated timestamp to track triggering latency #97612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kcons merged 10 commits into from
Aug 15, 2025
Merged

aci(feat): Use propagated timestamp to track triggering latency #97612

kcons merged 10 commits into from
Aug 15, 2025

Conversation

@kcons
Copy link
Member

@kcons kcons commented Aug 11, 2025

Create a timestamp before process_workflows_event and use it after alert triggering to report latency.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 11, 2025
@codecov
Copy link

codecov bot commented Aug 11, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 83.78378% with 6 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/rules/processing/delayed_processing.py 70.00% 6 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #97612       +/-   ##
===========================================
+ Coverage   66.32%   80.63%   +14.31%     
===========================================
  Files        8584     8593        +9     
  Lines      378501   378887      +386     
  Branches    24666    24666               
===========================================
+ Hits       251038   305522    +54484     
+ Misses     127094    72996    -54098     
  Partials      369      369

@kcons kcons changed the title aci(feat): Full path timestamp aci(feat): Use propagated timestamp to track triggering latency Aug 11, 2025
@kcons kcons marked this pull request as ready for review August 11, 2025 22:13
@kcons kcons requested review from a team as code owners August 11, 2025 22:13
cursor[bot]

This comment was marked as outdated.

Sign in to view

@kcons kcons requested a review from a team as a code owner August 12, 2025 17:57
@kcons kcons requested a review from cathteng August 12, 2025 17:57
cathteng
cathteng reviewed Aug 12, 2025
View reviewed changes
cathteng
cathteng reviewed Aug 12, 2025
View reviewed changes
cursor[bot]

This comment was marked as outdated.

Sign in to view

thetruecpaul
thetruecpaul approved these changes Aug 14, 2025
View reviewed changes
Copy link
Contributor

@thetruecpaul thetruecpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Failing tests look like they just need to expect the new argument.

cursor[bot]

This comment was marked as outdated.

Sign in to view

@kcons kcons merged commit 08d037a into master Aug 15, 2025
66 checks passed
@kcons kcons deleted the kcons/part1 branch August 15, 2025 16:49
@sentry
Copy link

sentry bot commented Aug 17, 2025 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

priscilawebdev pushed a commit that referenced this pull request Aug 25, 2025
@kcons @priscilawebdev
aci(feat): Use propagated timestamp to track triggering latency (#97612)
ebf70ba 
Create a timestamp before process_workflows_event and use it after alert
triggering to report latency.
andrewshie-sentry pushed a commit that referenced this pull request Aug 26, 2025
@kcons @andrewshie-sentry
aci(feat): Use propagated timestamp to track triggering latency (#97612)
617737d 
Create a timestamp before process_workflows_event and use it after alert
triggering to report latency.
constantinius pushed a commit that referenced this pull request Sep 1, 2025
@kcons @constantinius
aci(feat): Use propagated timestamp to track triggering latency (#97612)
9197083 
Create a timestamp before process_workflows_event and use it after alert
triggering to report latency.
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@cathteng cathteng cathteng approved these changes

@thetruecpaul thetruecpaul thetruecpaul approved these changes

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kcons @cathteng @thetruecpaul