chore(cell-actions): use popper strategy fixed instead of portalling #97593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nikkikapadia
left a comment
There was a problem hiding this comment.
just a prop naming comment
| | 'preventOverflowOptions' | ||
| | 'flipOptions' | ||
| | 'shouldApplyMinWidth' | ||
| | 'strategy' |
Member
There was a problem hiding this comment.
can we name this something else so we know exactly what it's for? maybe something like dropdownPortalStrategy or whatever (maybe don't use that name it doesn't make sense but you catch my drift)
Contributor
Author
There was a problem hiding this comment.
It's built into the popperJS library. I think useOverlayProps has a comment explaining it, but I can add a better comment in the dropdown menu file as well
Member
There was a problem hiding this comment.
ya if the name can't be changed then let's add a more detailed comment about it
nikkikapadia
approved these changes
Aug 15, 2025
priscilawebdev
pushed a commit
that referenced
this pull request
Aug 25, 2025
…97593) ### Changes Instead of portals, use the fixed strategy. Main reason is that portalling the dropdown to document body does not work with tables in modals due to stacking issues (e.g., planning to add cell actions to viewer table modal in dashboards) There should be no UI change to the dropdown. This change only applies when `discover-cell-actions-v2` is enabled.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 26, 2025
…97593) ### Changes Instead of portals, use the fixed strategy. Main reason is that portalling the dropdown to document body does not work with tables in modals due to stacking issues (e.g., planning to add cell actions to viewer table modal in dashboards) There should be no UI change to the dropdown. This change only applies when `discover-cell-actions-v2` is enabled.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Instead of portals, use the fixed strategy. Main reason is that portalling the dropdown to document body does not work with tables in modals due to stacking issues (e.g., planning to add cell actions to viewer table modal in dashboards)
There should be no UI change to the dropdown. This change only applies when
discover-cell-actions-v2is enabled.