Skip to content

feat(tasks) Simplify taskworker rollout options & update devservices/server#96966

Closed
markstory wants to merge 3 commits intomasterfrom
chore-simpler-taskworker-options
Closed

feat(tasks) Simplify taskworker rollout options & update devservices/server#96966
markstory wants to merge 3 commits intomasterfrom
chore-simpler-taskworker-options

Conversation

@markstory
Copy link
Member

@markstory markstory commented Aug 1, 2025

With the rollout of taskworkers complete in saas, we can simplify the rollout option and enable taskworkers by default in local development. I'm going to disable this option for the August self-hosted release and enable it for the September relase once docs have been published.

I've also updated the devservices mode configuration and devserver options to prefer taskworker but left escape hatches for running celery if required.

Refs getsentry/taskbroker#453

@markstory
feat(tasks) Simplify taskworker rollout options & update devservices/…
0fc4993 
…server

With the rollout of taskworkers complete in saas, we can simplify the
rollout option and enable taskworkers by default in local development.
I'm going to disable this option for the August self-hosted release and
enable it for the September relase once docs have been published.

I've also updated the devservices mode configuration and devserver
options to prefer taskworker but left escape hatches for running celery
if required.

Refs getsentry/taskbroker#453
@markstory markstory requested review from a team as code owners August 1, 2025 16:31
@markstory markstory requested a review from a team August 1, 2025 16:31
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 1, 2025
markstory added a commit to getsentry/self-hosted that referenced this pull request Aug 1, 2025
@markstory
feat: Continue using celery in self-hosted for now
1b89828 
Disable taskworkers for self-hosted until the documentation has been
published.

Refs getsentry/sentry#96966
@markstory markstory mentioned this pull request Aug 1, 2025
Merged
@codecov
Copy link

codecov bot commented Aug 1, 2025 •
edited
Loading

❌ 32 Tests Failed:

Tests completed Failed Passed Skipped
26985 32 26953 602
View the top 3 failed test(s) by shortest run time 
tests.sentry.tasks.test_relay::test_debounce
Stack Traces | 0.908s run time 
#x1B[1m#x1B[.../sentry/tasks/test_relay.py#x1B[0m:146: in test_debounce
    assert len(tasks) == 1
#x1B[1m#x1B[31mE   assert 0 == 1#x1B[0m
#x1B[1m#x1B[31mE    +  where 0 = len([])#x1B[0m
tests.sentry.tasks.test_relay::test_project_delete_option
Stack Traces | 0.969s run time 
#x1B[1m#x1B[.../sentry/tasks/test_relay.py#x1B[0m:229: in test_project_delete_option
    assert redis_cache.get(default_projectkey)["config"]["piiConfig"] == {}
#x1B[1m#x1B[31mE   KeyError: 'config'#x1B[0m
tests.sentry.tasks.test_relay::test_project_update_option
Stack Traces | 0.971s run time 
#x1B[1m#x1B[.../sentry/tasks/test_relay.py#x1B[0m:194: in test_project_update_option
    assert redis_cache.get(default_projectkey.public_key)["config"]["piiConfig"] == {
#x1B[1m#x1B[31mE   KeyError: 'config'#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@markstory markstory requested a review from a team as a code owner August 1, 2025 18:24
@markstory
Disable taskworker.enabled option in tests that use BurstRunner
38ac5ef 
BurstRunner will require some rework to make it compatible with
Taskworker dispatching.
@markstory markstory requested review from a team as code owners August 1, 2025 19:36
@markstory markstory marked this pull request as draft August 1, 2025 19:45
@markstory
Copy link
Member Author

markstory commented Aug 1, 2025

Converting to a draft as I'm going to need to break this down more.

aldy505 pushed a commit to getsentry/self-hosted that referenced this pull request Aug 4, 2025
@markstory
feat: Continue using celery in self-hosted for now (#3845)
3f48e35 
Disable taskworkers for self-hosted until the documentation has been
published.

Refs getsentry/sentry#96966
@TartanLeGrand TartanLeGrand mentioned this pull request Aug 5, 2025
Draft
@markstory markstory mentioned this pull request Aug 6, 2025
Closed
@getsantry
Copy link
Contributor

getsantry bot commented Aug 23, 2025

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Aug 23, 2025
@markstory
Copy link
Member Author

markstory commented Sep 10, 2025

Closing as this is a bit of a mess now.

@markstory markstory closed this Sep 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markstory @evanh