ref: replace space function with p.theme.space in core/button #95414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that we also have it available without chonk
natemoo-re
approved these changes
Jul 15, 2025
| height: auto; | ||
| min-height: auto; | ||
| padding: ${space(0.25)}; | ||
| padding: ${p.theme.space['2xs']}; |
Member
There was a problem hiding this comment.
This is unfortunate that we'll have to be inconsistent with dotted vs bracketed attribute access
Collaborator
Author
There was a problem hiding this comment.
yeah we talked about this too. @Jesse-Box favours xxs and xxl over 2xl and that would solve this problem too.
Member
There was a problem hiding this comment.
should be a pretty easy refactor if we decide to change the names 👍
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jul 21, 2025
This PR hoists `theme.space` up to the `commonTheme` so that we have it available without being narrowed to a `chonk` theme. This allows us to use it everywhere in place of the `space` function, which has been deprecated. `buttonBar` needs to be done in a follow-up, because it needs an API change including many call-side changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hoists
theme.spaceup to thecommonThemeso that we have it available without being narrowed to achonktheme. This allows us to use it everywhere in place of thespacefunction, which has been deprecated.buttonBarneeds to be done in a follow-up, because it needs an API change including many call-side changes.