feat(preprod) Add file id for install file #94642
Conversation
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
476dc43 to
71d745d
Compare
|
This PR has a migration; here is the generated SQL for for --
-- Add field installable_app_file_id to preprodartifact
--
ALTER TABLE "sentry_preprodartifact" ADD COLUMN "installable_app_file_id" bigint NULL;
CREATE INDEX CONCURRENTLY "sentry_preprodartifact_installable_app_file_id_26dbfd18" ON "sentry_preprodartifact" ("installable_app_file_id"); |
71d745d to
b6b2b4a
Compare
src/sentry/preprod/models.py
Outdated
| # Size analysis wont necessarily be run on every artifact (based on quotas) | ||
| analysis_file_id = BoundedBigIntegerField(db_index=True, null=True) | ||
|
|
||
| install_file_id = BoundedBigIntegerField(db_index=True, null=True) |
There was a problem hiding this comment.
nit: can you add a better name for this like installable_{app|artifact}_file_id? a comment would also be helpful.
b6b2b4a to
a5f30a3
Compare
a5f30a3 to
aa15510
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #94642 +/- ##
==========================================
- Coverage 87.93% 87.93% -0.01%
==========================================
Files 10418 10419 +1
Lines 602909 602917 +8
Branches 23448 23448
==========================================
+ Hits 530144 530147 +3
- Misses 72259 72264 +5
Partials 506 506 |
Adds file id for install file which will be either the ipa or apk that gets uploaded from launchpad
Adds file id for install file which will be either the ipa or apk that gets uploaded from launchpad