feat(simpleTable): Allow <SimpleTable> to accept any Div props
#94619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we can pass stuff like data-test-id as expected
evanpurkhiser
approved these changes
Jun 30, 2025
JonasBa
reviewed
Jun 30, 2025
| import {space} from 'sentry/styles/space'; | ||
|
|
||
| interface TableProps { | ||
| interface TableProps extends HTMLAttributes<HTMLDivElement> { |
Member
There was a problem hiding this comment.
Nit, but we should omit role attribute here since we are overriding it on the table
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so we can pass stuff like
data-test-idas expected