Skip to content

chore: Cleanup user-feedback-replay-clip FE#87770

Merged
ryan953 merged 1 commit intomasterfrom
ryan953/clean-user-feedback-replay-clip-fe
Mar 24, 2025
Merged

chore: Cleanup user-feedback-replay-clip FE#87770
ryan953 merged 1 commit intomasterfrom
ryan953/clean-user-feedback-replay-clip-fe

Conversation

@ryan953
Copy link
Member

@ryan953 ryan953 commented Mar 24, 2025

@ryan953 ryan953 requested a review from a team as a code owner March 24, 2025 18:56
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 24, 2025
@ryan953 ryan953 requested a review from a team March 24, 2025 18:57
() => import('sentry/components/events/eventReplay/replayClipPreview')
);
const LazyReplayPreviewComponent = lazy(
() => import('sentry/components/events/eventReplay/replayPreview')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this component? (non lazy version)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question! it's still imported in one other spot here:

import ReplayPreviewPlayer from 'sentry/components/events/eventReplay/replayPreviewPlayer';

@ryan953 ryan953 enabled auto-merge (squash) March 24, 2025 19:04
@ryan953 ryan953 merged commit 18597c6 into master Mar 24, 2025
43 checks passed
@ryan953 ryan953 deleted the ryan953/clean-user-feedback-replay-clip-fe branch March 24, 2025 19:09
ryan953 added a commit that referenced this pull request Mar 25, 2025
andrewshie-sentry pushed a commit that referenced this pull request Mar 27, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants