Skip to content

feat(feedback): add ff for ingest feedback topic#67747

Merged
aliu39 merged 2 commits intomasterfrom
aliu/ingest-feedback-ff
Mar 27, 2024
Merged

feat(feedback): add ff for ingest feedback topic#67747
aliu39 merged 2 commits intomasterfrom
aliu/ingest-feedback-ff

Conversation

@aliu39
Copy link
Copy Markdown
Member

@aliu39 aliu39 commented Mar 26, 2024

Relates to: #66100

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 26, 2024
@michellewzhang
Copy link
Copy Markdown
Contributor

do we also need to modify sever.py?

"organizations:session-replay": False,

@cmanallen

@aliu39
Copy link
Copy Markdown
Member Author

aliu39 commented Mar 26, 2024

do we also need to modify sever.py?

Oh yup, good call!

@aliu39 aliu39 requested a review from a team as a code owner March 26, 2024 21:58
@aliu39
Copy link
Copy Markdown
Member Author

aliu39 commented Mar 26, 2024

Added to EXPOSABLE_FEATURES so relay can read it from project config -- see comment here. Useful for future relay flags @cmanallen

@aliu39 aliu39 merged commit bb59152 into master Mar 27, 2024
@aliu39 aliu39 deleted the aliu/ingest-feedback-ff branch March 27, 2024 16:59
aliu39 added a commit that referenced this pull request Mar 27, 2024
@aliu39 aliu39 added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Mar 27, 2024
@getsentry-bot
Copy link
Copy Markdown
Contributor

PR reverted: 5773dab

getsentry-bot added a commit that referenced this pull request Mar 27, 2024
This reverts commit bb59152.

Co-authored-by: aliu3ntry <159852527+aliu3ntry@users.noreply.github.com>
aliu39 added a commit to getsentry/relay that referenced this pull request Apr 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants