feat(loader): Enable INP by default#66873
Merged
AbhiPrasad merged 2 commits intomasterfrom Mar 13, 2024
Merged
Conversation
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
edwardgou-sentry
approved these changes
Mar 13, 2024
mydea
approved these changes
Mar 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66873 +/- ##
==========================================
- Coverage 84.31% 84.23% -0.08%
==========================================
Files 5308 5308
Lines 237299 237299
Branches 41039 41039
==========================================
- Hits 200070 199890 -180
- Misses 37011 37191 +180
Partials 218 218 |
AbhiPrasad
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
enableInp: truefor browser tracing integration.We also flip the conditionals so we look for the function based integrations first, since
enableInpis only supported for that.Tested with getsentry/sentry-javascript#11081