feat(inbound-filters): Turn on some filters for new Javascript projects#62654
Merged
roggenkemper merged 7 commits intomasterfrom Jan 9, 2024
Merged
feat(inbound-filters): Turn on some filters for new Javascript projects#62654roggenkemper merged 7 commits intomasterfrom
roggenkemper merged 7 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #62654 +/- ##
==========================================
+ Coverage 81.30% 81.34% +0.03%
==========================================
Files 5201 5202 +1
Lines 230405 230418 +13
Branches 39815 39818 +3
==========================================
+ Hits 187334 187423 +89
+ Misses 37328 37251 -77
- Partials 5743 5744 +1
|
wedamija
approved these changes
Jan 8, 2024
Member
wedamija
left a comment
There was a problem hiding this comment.
Is there a longer term plan to enable this for older projects?
Member
Author
The next milestone is to do this for existing projects, but there is no currently timeline / plan for how we want to do this |
trillville
pushed a commit
that referenced
this pull request
Jan 19, 2024
…ts (#62654) this pr will update how projects are created so that new javascript platform projects have some of the inbound filters turned on by default. browser extension, health check transaction, legacy browser, and web crawler filters will be on by default for these new javascript based projects. it will not impact projects of any other platform, nor will it change the filters for any existing project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr will update how projects are created so that new javascript platform projects have some of the inbound filters turned on by default. browser extension, health check transaction, legacy browser, and web crawler filters will be on by default for these new javascript based projects. it will not impact projects of any other platform, nor will it change the filters for any existing project.