feat(feedback): Sends MessageEvent when error page embed is closed#59885
feat(feedback): Sends MessageEvent when error page embed is closed#59885AbhiPrasad merged 3 commits intogetsentry:masterfrom
Conversation
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #59885 +/- ##
=======================================
Coverage 80.86% 80.87%
=======================================
Files 5183 5183
Lines 227620 227618 -2
Branches 38300 38299 -1
=======================================
+ Hits 184072 184085 +13
+ Misses 37928 37918 -10
+ Partials 5620 5615 -5
|
459fe56 to
ec6d03a
Compare
There was a problem hiding this comment.
| window.parent.postMessage('reportdialog_closed', '*'); | |
| window.parent.postMessage('sentry_reportdialog_closed', '*'); |
Let's namespace to sentry to reduce possible collisions/confusions as much as possible
There was a problem hiding this comment.
How about even more of an indication that it comes from a library: __sentry_reportdialog_closed__?
markstory
left a comment
There was a problem hiding this comment.
Selenium tests and embed logic changes look good to me.
Sends `reportdialog_closed` via window.postMessage to the parent of the error page embed in preparation of supporting an `onClose` callback in @sentry/browser `showReportDialog`. Fixes getsentry/sentry-javascript#9433
ec6d03a to
5fffdc0
Compare
AbhiPrasad
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR - lets get this deployed and then merge in changes for SDK + docs :)
|
/gcbrun |
My pleasure, please let me know if there's anything else needed. |
|
/gcbrun |
Sends
reportdialog_closedvia window.postMessage to the parent of the error page embed in preparation of supporting anonClosecallback in @sentry/browsershowReportDialog.Fixes getsentry/sentry-javascript#9433
Please see the accompanying PRs:
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.