feat(feedback): Add sentry prefix to reportdialog_closed MessageEvent

arya-s · arya-s · commit 5fffdc0dfd5d · 2023-11-22T18:18:46.000+09:00
diff --git a/src/sentry/templates/sentry/error-page-embed.js b/src/sentry/templates/sentry/error-page-embed.js
@@ -151,7 +151,7 @@
     }
     this.element.parentNode.removeChild(this.element);
     if (window.parent) {
-      window.parent.postMessage('reportdialog_closed', '*');
+      window.parent.postMessage('__sentry_reportdialog_closed__', '*');
     }
   };
 
diff --git a/tests/acceptance/test_error_page_embed.py b/tests/acceptance/test_error_page_embed.py
@@ -38,7 +38,7 @@ def wait_for_error_page_embed(self):
 
     def wait_for_reportdialog_closed_message(self):
         self.browser.wait_until_script_execution(
-            """return window.__error_page_embed_received_message__ === 'reportdialog_closed'"""
+            """return window.__error_page_embed_received_message__ === '__sentry_reportdialog_closed__'"""
         )
 
     def test_closed_message_received_on_close_button_click(self):

Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@`
`151`	`151`	`}`
`152`	`152`	`this.element.parentNode.removeChild(this.element);`
`153`	`153`	`if (window.parent) {`
`154`		`- window.parent.postMessage('reportdialog_closed', '*');`
	`154`	`+ window.parent.postMessage('__sentry_reportdialog_closed__', '*');`
`155`	`155`	`}`
`156`	`156`	`};`
`157`	`157`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ def wait_for_error_page_embed(self):`
`38`	`38`
`39`	`39`	`def wait_for_reportdialog_closed_message(self):`
`40`	`40`	`self.browser.wait_until_script_execution(`
`41`		`- """return window.__error_page_embed_received_message__ === 'reportdialog_closed'"""`
	`41`	`+ """return window.__error_page_embed_received_message__ === '__sentry_reportdialog_closed__'"""`
`42`	`42`	`)`
`43`	`43`
`44`	`44`	`def test_closed_message_received_on_close_button_click(self):`