Skip to content

ref(loader): Streamline var usage#47316

Merged
mydea merged 2 commits intomasterfrom
fn/use-loader-vars
May 2, 2023
Merged

ref(loader): Streamline var usage#47316
mydea merged 2 commits intomasterfrom
fn/use-loader-vars

Conversation

@mydea
Copy link
Copy Markdown
Member

@mydea mydea commented Apr 13, 2023

Update usage of the passed in variables, so we re-use strings as much as possible.

@mydea mydea requested a review from AbhiPrasad April 13, 2023 12:29
@mydea mydea self-assigned this Apr 13, 2023
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Apr 13, 2023
@github-actions
Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2023

Codecov Report

Merging #47316 (0d3abad) into master (85b996a) will increase coverage by 19.49%.
The diff coverage is n/a.

❗ Current head 0d3abad differs from pull request most recent head 1aa1404. Consider uploading reports for the commit 1aa1404 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #47316       +/-   ##
===========================================
+ Coverage   61.37%   80.87%   +19.49%     
===========================================
  Files        4738     4770       +32     
  Lines      201153   201584      +431     
  Branches    11542    11557       +15     
===========================================
+ Hits       123465   163031    +39566     
+ Misses      77433    38297    -39136     
- Partials      255      256        +1     

see 1563 files with indirect coverage changes

@mydea mydea force-pushed the fn/use-loader-vars branch from 0b9259e to 2552ecc Compare April 17, 2023 15:55
@mydea mydea force-pushed the fn/use-loader-vars branch from 2552ecc to f57c96e Compare April 26, 2023 07:49
@mydea mydea force-pushed the fn/use-loader-vars branch from f57c96e to a419f62 Compare April 26, 2023 11:32
mydea added a commit to getsentry/sentry-javascript that referenced this pull request Apr 26, 2023
mydea added a commit to getsentry/sentry-javascript that referenced this pull request Apr 26, 2023
mydea added a commit to getsentry/sentry-javascript that referenced this pull request Apr 26, 2023
mydea added a commit to getsentry/sentry-javascript that referenced this pull request Apr 27, 2023
@mydea mydea force-pushed the fn/use-loader-vars branch from a419f62 to 0d3abad Compare April 27, 2023 12:34
@mydea mydea force-pushed the fn/use-loader-vars branch from 0d3abad to 1aa1404 Compare April 28, 2023 07:45
@mydea mydea merged commit 04b71a3 into master May 2, 2023
@mydea mydea deleted the fn/use-loader-vars branch May 2, 2023 08:19
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants