feat(loader): Ensure default integrations are added & work for performance#46995
Merged
feat(loader): Ensure default integrations are added & work for performance#46995
Conversation
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
AbhiPrasad
approved these changes
Apr 6, 2023
4152107 to
b20b711
Compare
AbhiPrasad
approved these changes
Apr 6, 2023
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Nothing seems to break when I ran in a local app! Let's 
schew2381
pushed a commit
that referenced
this pull request
Apr 12, 2023
schew2381
pushed a commit
that referenced
this pull request
Apr 12, 2023
owensk
pushed a commit
that referenced
this pull request
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This re-implements parts of the reverted #46447.
This updates the loader script to:
initis called before other methods, so e.g. captureException etc. will only be called afterwardsThe other part is #46994 - this kind-of depends on this as without this the integrations will not be added (as the sample rates are not set). However they are only indirectly linked and can be merged/deployed separately.
Verification steps