feat(settings): Ensure JS Loader validates SDK version & products#46604
Merged
feat(settings): Ensure JS Loader validates SDK version & products#46604
Conversation
AbhiPrasad
reviewed
Mar 30, 2023
static/app/views/settings/project/projectKeys/details/keySettings.tsx
Outdated
Show resolved
Hide resolved
AbhiPrasad
approved these changes
Mar 31, 2023
71bfefe to
c9de303
Compare
Member
|
shouldn't the SDK loader automatically be updated if the user selects Screen.Recording.2023-04-04.at.15.16.50.mov |
priscilawebdev
approved these changes
Apr 4, 2023
Member
priscilawebdev
left a comment
There was a problem hiding this comment.
left a question but it looks good to me 😉
Member
Author
You mean the URL? The url always remains the same, only the code that is served by it changes in the background :) |
Member
|
I mean the SDK version in the drop-down |
Member
Author
Ah, I see! Well the way it works is that it untoggles replay if you select an older SDK version: Screen.Recording.2023-04-05.at.10.37.47.mov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled out the frontend changes from #46447.
When you switch your SDK version to <7, it automatically removes performance & tracing. This should ensure we do not get into a weird state.
ref #46436