Skip to content

fix(monitors): Store duration as milliseconds#45311

Merged
jan-auer merged 1 commit intomasterfrom
fix/monitors-duration-ms
Mar 2, 2023
Merged

fix(monitors): Store duration as milliseconds#45311
jan-auer merged 1 commit intomasterfrom
fix/monitors-duration-ms

Conversation

@jan-auer
Copy link
Member

@jan-auer jan-auer commented Mar 2, 2023 •
edited
Loading

Follow-up to #45079. Stores durations correctly when they are specified by the
client. The Relay and Kafka protocol specify them as seconds, and the consumer
misses a conversion to integer milliseconds.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 2, 2023
@codecov
Copy link

codecov bot commented Mar 2, 2023 •
edited
Loading

Codecov Report

Merging #45311 (86a6e5e) into master (d1cf95d) will increase coverage by 14.19%.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #45311       +/-   ##
===========================================
+ Coverage   57.10%   71.29%   +14.19%     
===========================================
  Files        4688     4697        +9     
  Lines      198246   198536      +290     
  Branches    12020    12020               
===========================================
+ Hits       113203   141552    +28349     
+ Misses      84781    56722    -28059     
  Partials      262      262
Impacted Files Coverage Δ
src/sentry/api/endpoints/monitor_checkins.py 37.07% <0.00%> (-0.57%) ⬇️
...y/services/hybrid_cloud/lost_password_hash/impl.py 69.23% <0.00%> (ø)
src/sentry/mediators/alert_rule_actions/creator.py 95.65% <0.00%> (ø)
src/sentry/attachments/redis.py 100.00% <0.00%> (ø)
...rc/sentry/mediators/alert_rule_actions/__init__.py 100.00% <0.00%> (ø)
src/sentry/monitoring/queues.py 41.93% <0.00%> (ø)
src/sentry/middleware/api_gateway.py 100.00% <0.00%> (ø)
src/sentry/services/hybrid_cloud/app/impl.py 72.85% <0.00%> (ø)
src/sentry/charts/chartcuterie.py 84.31% <0.00%> (ø)
src/sentry/integrations/pagerduty/utils.py 80.55% <0.00%> (ø)
... and 1036 more

@jan-auer jan-auer self-assigned this Mar 2, 2023
@jan-auer jan-auer requested a review from a team March 2, 2023 15:44
@jan-auer jan-auer enabled auto-merge (squash) March 2, 2023 15:48
@jan-auer jan-auer merged commit 8d9d24a into master Mar 2, 2023
@jan-auer jan-auer deleted the fix/monitors-duration-ms branch March 2, 2023 15:49
evanpurkhiser added a commit that referenced this pull request Mar 13, 2023
@evanpurkhiser
fix(monitors): Correct date_added offset
8c062ef 
I believe this was missed in #45311
@evanpurkhiser evanpurkhiser mentioned this pull request Mar 13, 2023
Merged
evanpurkhiser added a commit that referenced this pull request Mar 14, 2023
@evanpurkhiser
fix(monitors): Correct date_added offset
ce07217 
I believe this was missed in #45311
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@rjo100 rjo100 rjo100 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jan-auer jan-auer

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jan-auer @rjo100