feat(loader): Add feature flag for new dynamic SDK loader#44228
Merged
AbhiPrasad merged 2 commits intomasterfrom Feb 7, 2023
Merged
feat(loader): Add feature flag for new dynamic SDK loader#44228AbhiPrasad merged 2 commits intomasterfrom
AbhiPrasad merged 2 commits intomasterfrom
Conversation
Lms24
approved these changes
Feb 7, 2023
AbhiPrasad
added a commit
that referenced
this pull request
Feb 10, 2023
In this PR we add a new `JavaScriptSdkDynamicLoader` view that will render the new dynamic js sdk loader as a template. This view does nothing atm, but adding functionality will be the next step. Currently this is not gated by the feature flag introduced with #44228, but will be as soon as it has complicated logic. As a next step, we need to introduce a `JS_SDK_DYNAMIC_LOADER_SDK_VERSION` config value, and then move to adding project dsn settings for the dynamic loader.
wmak
pushed a commit
that referenced
this pull request
Feb 16, 2023
wmak
pushed a commit
that referenced
this pull request
Feb 16, 2023
In this PR we add a new `JavaScriptSdkDynamicLoader` view that will render the new dynamic js sdk loader as a template. This view does nothing atm, but adding functionality will be the next step. Currently this is not gated by the feature flag introduced with #44228, but will be as soon as it has complicated logic. As a next step, we need to introduce a `JS_SDK_DYNAMIC_LOADER_SDK_VERSION` config value, and then move to adding project dsn settings for the dynamic loader.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #44225
Add
organizations:js-sdk-dynamic-loader, a new feature flag that gates functionality for the JS SDK Dynamic Loader we are building, details about that here: getsentry/sentry-javascript#6944The next step here is for us to add a view that will render this dynamic loader, similar to the existing setup.