Skip to content

fix(btn-group-break): quick fix for issues table nav items#15585

Merged
doralchan merged 2 commits intomasterfrom
fix/btn-group
Nov 13, 2019
Merged

fix(btn-group-break): quick fix for issues table nav items#15585
doralchan merged 2 commits intomasterfrom
fix/btn-group

Conversation

@doralchan
Copy link
Contributor

@doralchan doralchan commented Nov 13, 2019

Screen Shot 2019-11-13 at 1 50 41 PM
Screen Shot 2019-11-13 at 1 50 29 PM
Screen Shot 2019-11-13 at 1 50 15 PM

  • Fixed btn-group with flex
  • Moved bookmark content into dropdown menu
  • Changing breakpoints

@doralchan doralchan requested review from billyvg and ckj November 13, 2019 22:19
@doralchan
Copy link
Contributor Author

Note: Going to hold off on refactoring grid-emotion out for now seeing that it must align with the table body.

Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 🙏 🙏 🙏

@doralchan doralchan merged commit 56de7ca into master Nov 13, 2019
@doralchan doralchan deleted the fix/btn-group branch November 13, 2019 22:33
@markstory
Copy link
Member

👏

jan-auer added a commit that referenced this pull request Nov 13, 2019
* master: (59 commits)
  fix(btn-group-break): quick fix for issues table nav items (#15585)
  feat(ui): Change `<SmartSearchBar>` to simulate "search" on En… (#15345)
  ref: Update semaphore to 0.4.61 (#15574)
  fix(api): Fix failing snuba test in Django 1.9
  chore(ts): convert sentry app component files (#15575)
  build(github-actions): RIP github actions (#15577)
  feat(ui): Adapt user-feedback page to lightweight organization context (#15551)
  ref(logo replacement): converted pngs to svgs (#15552)
  Remove unused animated-ellipsis (#15515)
  fix: Fix `get_participants` to use `__in` correctly.
  build(webpack): Remove `lodash-webpack-plugin` (#15521)
  moved the bulk of plugins from test_only_plugins into new_sentry_plugins (#15468)
  ref: Remove "store.save-event-skips-nodestore" option from code (#15568)
  logging(app-context): adds more logging context for slack api errors (#15557)
  build(babel): Remove `@babel/polyfill` (#15564)
  chore(ts): convert sentryApps (#15565)
  chore(ts): convert SentryAppIcon (#15569)
  fix: Avoid updating with None (#15549)
  feat(api): Project key creation rate limit params (#15366)
  fix(api): Fix failing snuba test in Django 1.9
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants