fix: Pass an empty array to $.param instead of an empty string when options.query is falsey#14051
Merged
fix: Pass an empty array to $.param instead of an empty string when options.query is falsey#14051
Conversation
…ptions.query is falsey
billyvg
approved these changes
Jul 17, 2019
Member
billyvg
left a comment
There was a problem hiding this comment.
Thanks for looking into this, I wonder why the errors only started popping up more often this week and why only Firefox.
Member
Author
scefali
pushed a commit
that referenced
this pull request
Jul 17, 2019
…ptions.query is falsey (#14051)
dashed
added a commit
that referenced
this pull request
Jul 17, 2019
dashed
added a commit
that referenced
this pull request
Jul 17, 2019
Member
Author
|
Relates to openwpm/OpenWPM#408 and is isolated to Firefox browsers |
BYK
reviewed
Jul 18, 2019
| @@ -166,6 +166,7 @@ export class Client { | |||
| let query; | |||
| try { | |||
| query = $.param(options.query || '', true); | |||
Member
There was a problem hiding this comment.
Should we not remove the old line here?
Member
There was a problem hiding this comment.
He got it in a separate PR i think
Member
Author
There was a problem hiding this comment.
Yea I got it here #14061
git stash failed me 😢
HazAT
added a commit
that referenced
this pull request
Jul 19, 2019
* master: ref(admin): Convert user edit page to react (#14074) ref: Remove unused Group.get_oldest_event and legacy events behavior (#14038) ref(api): Update DELETE users/ to support hard deleting (#14068) test(OrganizationDiscoverSavedQueryDetailTest): Stabilize put test (#14077) meta(readme): Sentry logo should link to sentry.io (#14076) ref: Remove duplicate column (#14073) App platform/update permissions token auth (#14046) feat: Support issue IDs as canonical parameters ref: Change to new traceparent header for Python SDK (#14070) feat: Use option to force-disable transaction events (#14056) feat(apm): Register option to force-disable transaction events (#14055) Feat/mark sentry app installed put route (#14060) ref: Remove unused Group.event_set property (#14036) fix: Filter out groups that are pending deletion/merge from `by_qualified_short_id` (SEN-849) fix(ui): Fix resolve/ignore actions for accounts without multi… (#14058) Fix: Remove extra $.param introduced in GH-14051 (#14061) feat: Use Snuba for Group.from_event_id (#14034) fix(ui) Display implicit default sort and default to descending (#14042) fix(github) Fix 404s not being handled in repository search (#14030) fix: Pass an empty array to $.param instead of an empty string when options.query is falsey (#14051) # Conflicts: # src/sentry/utils/sdk.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is likely being loaded onto customer's browsershttps://github.com/splunk/splunk-sdk-javascript/blob/700d149fba3d5b38db06c0adf8739f5182aaf07d/lib/ui/charting/util.js#L1045-L1056and is causing
this.split is not a functionerrors due to the way jQuery is building the params by traversing enumerable props and the props from the prototype chain: https://github.com/jquery/jquery/blob/b14ce54334a568eaaa107be4c441660a57c3db24/src/serialize.js#L82The workaround is to use an empty array instead of an empty string when
options.queryis falsey. As per jquery's docs: https://api.jquery.com/jQuery.param/Fixes JAVASCRIPT-XYZ
Fixes JAVASCRIPT-1ABN