ref(ui): Consolidate server frontend hydration logic#13828
Merged
evanpurkhiser merged 1 commit intomasterfrom Jun 26, 2019
Merged
Conversation
evanpurkhiser
commented
Jun 26, 2019
evanpurkhiser
commented
Jun 26, 2019
73266b4 to
6a65153
Compare
BYK
approved these changes
Jun 26, 2019
Member
There was a problem hiding this comment.
nit: move this to a const or make it configurable from the API?
| createReactClass, | ||
| }; | ||
|
|
||
| // The SentryApp global contains exported app modules for use in javascript |
Member
There was a problem hiding this comment.
Suggested change
| // The SentryApp global contains exported app modules for use in javascript | |
| // The SentryApp global contains exported app modules for use in JavaScript |
| }; | ||
|
|
||
| // Make globals available on the window object | ||
| Object.keys(globals).forEach(name => (window[name] = globals[name])); |
| ); | ||
| } else if (languageOverride) { | ||
| setLocale(languageOverride); | ||
| languageCode = queryString.lang || config.user.options.language || languageCode; |
Member
There was a problem hiding this comment.
TODO: see if we can also leverage navigator.language as a last resort.
evanpurkhiser
added a commit
that referenced
this pull request
Jun 27, 2019
This reverts commit 596192d.
evanpurkhiser
added a commit
that referenced
this pull request
Jun 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets us one step closer to being able to boot the application without the backed serving the layout.html