ref(objectstore): Make ObjectstoreEndpoint unauthenticated #114137
Merged
Conversation
… feature gate Drops the `organizations:objectstore-endpoint` feature flag, renames `OrganizationObjectstoreEndpoint` to `ObjectstoreEndpoint`, and switches the base class from `OrganizationEndpoint` to `Endpoint` with no DRF auth or permission classes. Authentication is performed by Objectstore via the `Authorization` or `X-Os-Auth` header. The `organization_id_or_slug` URL kwarg remains for API Gateway cell routing only.
Clarified the description of the ObjectstoreEndpoint class.
matt-codecov
approved these changes
Apr 28, 2026
matt-codecov
left a comment
Contributor
There was a problem hiding this comment.
cc @michelletran-sentry for vis
objectstore auth enforcement has been enabled so we are removing django auth here as it is redundant. that IDOR should also be fixed by the enforcement change
Member
Author
|
Ah yeah. Although I think the bots will go even crazier in saying that this is vulnerable now that the endpoint is unauthenticated. |
Contributor
|
PR reverted: 6ddfc44 |
cleptric
pushed a commit
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reshapes the Objectstore proxy endpoint so that authentication is performed entirely by Objectstore.
This allows us to lift the feature flag gate, and is safe now that we're enforcing auth checks.