feat(code_review): Use GitHub org names whitelisting for testing #105844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have tried using `s4s` and `s4s2` for testing but there are all sorts of problems. We will be using the GitHub org to determine if to send to Seer.
suejung-sentry
approved these changes
Jan 7, 2026
Member
suejung-sentry
left a comment
There was a problem hiding this comment.
I'll follow up with a PR seeing if I can get this wired into options-automator so we don't have to wait the up to 12 hours for re-deploys to add to the list
| repository = event.get("repository", {}) | ||
| github_org = None | ||
| if isinstance(repository, dict): | ||
| github_org = repository.get("owner", {}).get("login") |
Member
There was a problem hiding this comment.
Looks good. I double checked this would be the payload shape. I think this is not populated as such for Installation events but we're not forwarding those after all so we're okay
Member
Author
There was a problem hiding this comment.
A reminder to any readers. This is a temporary hack.
armenzg
commented
Jan 8, 2026
| GH_ORGS_TO_ONLY_SEND_TO_SEER = { | ||
| "sentry-ecosystem", # on s4s2 & us | ||
| "coding-workflows-s4s", # on us | ||
| "sentry-coding-workflows", # on us |
Member
Author
There was a problem hiding this comment.
We're testing in these two orgs:
https://github.com/sentry-coding-workflows/testing-repo/pull/1
https://github.com/sentry-ecosystem/coding-workflows-s4s-testing/pull/1
armenzg
added a commit
that referenced
this pull request
Jan 12, 2026
In #105844, we started using GitHub whitelisting to help us debug issues in `s4s` and `s4s2`. We're at the point we don't need this.
This was referenced Jan 12, 2026
armenzg
added a commit
that referenced
this pull request
Jan 14, 2026
In #105844 (while we were debugging `s4s2`) we switched to using whitelisted GitHub orgs rather than options. Now that we've made progress in s4s2 we can add using options back again. We will drop whitelisted orgs in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have tried using
s4sands4s2for testing but there are all sorts of problems.We will be using the GitHub org to determine if to send to Seer.